Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove resource_set limitations#28013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
agomezl wants to merge4 commits intobazelbuild:master
base:master
Choose a base branch
Loading
fromagomezl:generic_resource_set

Conversation

@agomezl
Copy link

Currently, the resource_set attribute ofctx.actions.run (an similar) can only be set to a function returning a dictionary with a limited set of keys/resources (mem, cpu, and local_test). This change removes this restriction, allowing any resource know to the resource manager.

RELNOTES:resource_set function can now reference custom resources

Closes#27950

@google-cla
Copy link

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View thisfailed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Currently, the resource_set attribute of `ctx.actions.run` (an similar)can only be set to a function returning a dictionary with a limited setof keys/resources (mem, cpu, and local_test). This change removes thisrestriction, allowing any resource know to the resource manager.RELNOTES: `resource_set` function can now reference custom resourcesClosesbazelbuild#27950
@agomezl
Copy link
Author

agomezl commentedDec 16, 2025•
edited
Loading

Ok, here is the code for#27950. Still missing:

  • Update the documentation
  • Find some good place for tests (Help appreciated 😜)

@fmeum
Copy link
Collaborator

@agomezlagomezl marked this pull request as ready for reviewDecember 16, 2025 21:53
@agomezlagomezl requested a review froma team as acode ownerDecember 16, 2025 21:53
@agomezlagomezl requested review fromgregestren and removed request fora teamDecember 16, 2025 21:53
@github-actionsgithub-actionsbot added team-Configurabilityplatforms, toolchains, cquery, select(), config transitions awaiting-reviewPR is awaiting review from an assigned reviewer labelsDec 16, 2025
@agomezl
Copy link
Author

agomezl commentedDec 16, 2025•
edited
Loading

I don't know what is the deal with themacos-arm64 tests, but they also fail in my personal mac with:

ERROR: Error computing the main repository mapping: Error accessing registry https://bcr.bazel.build/: Failed to fetch registry file https://bcr.bazel.build/modules/rules_cc/0.2.14/MODULE.bazel: No route to host

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gregestrengregestrenAwaiting requested review from gregestrengregestren is a code owner automatically assigned from bazelbuild/configurability

Assignees

No one assigned

Labels

awaiting-reviewPR is awaiting review from an assigned reviewerteam-Configurabilityplatforms, toolchains, cquery, select(), config transitions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allowresource_set's callback to return custom resources

2 participants

@agomezl@fmeum
[8]ページ先頭
©2009-2025 Movatter.jp