Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork637
Comparing changes
Open a pull request
base repository:bazel-contrib/rules_python
Uh oh!
There was an error while loading.Please reload this page.
base:main
head repository:bazel-contrib/rules_python
Uh oh!
There was an error while loading.Please reload this page.
compare:release/1.5
Uh oh!
There was an error while loading.Please reload this page.
- 12commits
- 25files changed
- 7contributors
Commits on Jun 14, 2025
Fix argument name typo (#2984)
```ERROR: Traceback (most recent call last): File ".../rules_python++pip+rules_mypy_pip_312_click/BUILD.bazel", line 5, column 20, in <toplevel> whl_library_targets( File ".../rules_python+/python/private/pypi/whl_library_targets.bzl", line 337, column 53, in whl_library_targets "//conditions:default": create_inits( File ".../rules_python+/python/private/pypi/namespace_pkgs.bzl", line 72, column 25, in create_inits for out in get_files(**kwargs): File ".../rules_python+/python/private/pypi/namespace_pkgs.bzl", line 20, column 5, in get_files def get_files(*, srcs, ignored_dirnames = [], root = None):Error: get_files() got unexpected keyword argument: ignore_dirnames (did you mean 'ignored_dirnames'?)```(cherry picked from commit94e08f7)
Commits on Jun 17, 2025
fix: use platform_info.target_settings in toolchain aliases (#3001)
During the refactor we forgot one more place where the `flag_values` onthe platform information was used. They were no longer populated andbroke.The solution is to use `selects.config_setting_group` to maintainbehaviour and in order to smoke test I have added a target to verifythat the aliases work.Related to#2875Fixes#2993Co-authored-by: Richard Levasseur <richardlev@gmail.com>(cherry picked from commit107a878)
Commits on Jun 20, 2025
fix(toolchains): use posix-compatible exec -a alternative (#3010)
The `exec -a` command doesn't work in dash, the default shell forUbuntu/debian.To work around, use `sh -c`, which is posix and dash compatible. Thisallows changingthe argv0 while invoking a different command. Also adds a test to verifythe theruntime_env toolchain works with bootstrap script.Fixes#3009(cherry picked from commitc4543cd)
Commits on Jun 25, 2025
fix(pypi): namespace_pkgs should pass correct arguments (#3026)
It seems that the only function that did not have unit tests have bugsand the integration tests did not catch it because we weren't creatingnamespacepkg `__init__.py` files.This change fixes the bug, adds a unit test for the remaining untestedfunction.Fixes#3023Co-authored-by: Richard Levasseur <richardlev@gmail.com>(cherry picked from commit4978027)
Commits on Jun 26, 2025
fix: work around version parsing by only parsing if site-packages is …
…enabled (#3031)There's a bug in the version string parser that doesn't handle localidentifiers correctly.Thankfully, it's only activated in the experimental code path when sitepackages forlibraries is eanbled. Moving the logic within that block works aroundit.Work around for#3030(cherry picked from commitaab2650)
Commits on Jul 6, 2025
fix(pypi): only generate namespace package shims if implicit namespac…
…es are disabled (#3059)The refactoring to move the pkgutil shim generation to build phaseinvertedthe logic for when it should be activated. When`enable_implicit_namespace_pkgs=True`, it means to not generate thepkgutil shims("respect the Python definition of the namespace package").To fix, just invert the logic that activates it.A test will be added in a subsequent PR because the necessary helperisn'tin the 1.5 branch.Fixes#3038---------Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>(cherry picked from commit47c681b)
Commits on Aug 11, 2025
fix: Don't let deprecated test targets get matched by '...' (#3045)
This fixes "target '//foo_test' is deprecated: Use 'foo.test' instead.The '*_test' target will be removed in the next major release." beingwarned about once per `compile_pip_requirement` call when running `bazeltest ...`.Work towards#2976(cherry picked from commit4e22d25)
fix(pypi): support properly installing sdists via pypi without index (#…
…3115)This fixes the subtle bug introduced in#2871, where we were droppingthe URL from the requirement, because we can download the sdistdirectly. We cannot add --no-index because sdists in general mayrequire extra build dependencies and we had already issues previously(see 0.36 release notes).Fixes#2363Fixes#3131---------Co-authored-by: Richard Levasseur <richardlev@gmail.com>(cherry picked from commitf6dd386)Cherry-pick notes: adapted the changelog to mention 1.5.2
aignas committedAug 11, 2025 chore(deps): upgrade bazel-skylib to 1.8.1 (#3118)
With most recent bazel versions, older versions of rules_python startedspewing a lot of warnings due to us using `bazel-skylib` for copyingfiles around.The only solution is to bump the bazel-skylib version.Fixes#3113---------Co-authored-by: Richard Levasseur <richardlev@gmail.com>(cherry picked from commit673cd76)Cherry-pick notes: adapted changelog to mention 1.5.2
aignas committedAug 11, 2025 fix(core): do not assume rules_python runtime (#3134)
This change reverts the behaviour where we assume that particularattributes will be always present - if bazel is doing autoloading forWORKSPACE builds (7.6.1), then we will crash with attribute error.I could not think how to add a unit test, which would test this fixbecause it seems to only happen with a released version of rules_pythonwhere we are not using `local_repository` override.Fixes#3119---------Co-authored-by: Richard Levasseur <richardlev@gmail.com>(cherry picked from commitacf7507)Cherry-pick notes: adjusted changelog to mention 1.5.2
fix(local-toolchains): don't watch non-existent include directory (#3048
)Apparently, Macs can mis-report their include directory.Since includes are only needed if C extensions are built, skip watchingthe directoryif it doesn't exist.Work around for#3043---------Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>(cherry picked from commitbe55942)
Commits on Aug 28, 2025
backport: PR#3178 to 1.5 (#3217)
fix(local_runtime): Search for libs in sys._base_executable whenavailable. (#3178) Search directory for libraries should look in the same directory assys._base_executable. Since sys._base_executable may be unset, fallbackto sys.executable Found this when trying to build using a venv for[tensorstore](https://github.com/google/tensorstore) on Windows: * Github CI uses nuget to download Python. * Build sets up a Python venv. The venv does not include all the lib directories required to link anextension.Fixes#3172 --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com>---------Co-authored-by: Laramie Leavitt <lar@google.com>Co-authored-by: Richard Levasseur <richardlev@gmail.com>
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff main...release/1.5
Uh oh!
There was an error while loading.Please reload this page.