- Notifications
You must be signed in to change notification settings - Fork1.1k
Allow groups of attributes to be set via a toolbar dialog#1197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
brendon wants to merge10 commits intobasecamp:mainChoose a base branch frombrendon:target-blank
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
10 commits Select commitHold shift + click to select a range
647ac21 Add a new text_attribute called `target` using the `a` group tag
brendon073f0d7 Add target as an allowed attribute to the sanitiser
brendon5098d1d Modify the toolbar controller to allow setting groups of attributes
brendon94151ff Allow createContainerElement to cope with more than one attribute on …
brendon7cf80bb Remove an attribute if the checkbox isn't checked
brendon09cccbf Use const not let as the variable isn't variable
brendon5c9b9ba Update ci.yml
brendon0b666a1 Update ci.yml
brendonf15055b Fix dialog attribute splitting and wrapping
brendon9dc1990 Prevent chrome page reload errors in testing locally
brendonFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Remove an attribute if the checkbox isn't checked
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit7cf80bbf28a55dba7e37df04be36590d9e547023
There are no files selected for viewing
2 changes: 2 additions & 0 deletionssrc/trix/controllers/toolbar_controller.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.