- Notifications
You must be signed in to change notification settings - Fork1.1k
Fix CI#1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Fix CI#1072
Uh oh!
There was an error while loading.Please reload this page.
Conversation
d1b89b8 toe1b2fdaCompared89ec5e to6a9d7b0Comparec1b7456 tobed325aComparebed325a tod536282Compareseanpdoyle commentedJan 30, 2024
seanpdoyle commentedJan 30, 2024
After more investigation, I believe the issue is that forksdo not inherit repository secrets:
This means that contributors submitting pull requests are executing their own suites in their own CI environments withoutaccess to Do contributors need to register their own accounts and get their own secrets? |
afcapel commentedJan 30, 2024
Ugh, that's quite a hurdle for contributing. Ideally we would run the tests from the GitHub actions instance if But there must be something else going on. The test randomly fail some times even when the |
Allows forks to run tests on GitHub Actions without having to have accessto the SauceLabs secret.Ref.#1072 (comment)
Allows forks to run tests on GitHub Actions without having to have accessto the SauceLabs secret.Ref.#1072 (comment)
afcapel commentedFeb 2, 2024
@seanpdoyle I've updated the CI script to only run tests on SauceLabs if it has access to an |
Uh oh!
There was an error while loading.Please reload this page.
Test against the latest browser and OS versions. Android 9 is EOLed, test instead against Android 11 which is the oldest version still receiving updates.
Also test the latest Safari version.