Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix CI#1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
afcapel wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromupdate-browser-versions
Open

Fix CI#1072

afcapel wants to merge1 commit intomainfromupdate-browser-versions

Conversation

@afcapel
Copy link
Contributor

@afcapelafcapel commentedJul 20, 2023
edited
Loading

Test against the latest browser and OS versions. Android 9 is EOLed, test instead against Android 11 which is the oldest version still receiving updates.

Also test the latest Safari version.

@afcapelafcapelforce-pushed theupdate-browser-versions branch 3 times, most recently fromd1b89b8 toe1b2fdaCompareJuly 20, 2023 12:44
@afcapelafcapel changed the titleUpdate browser versionsFix CIJul 20, 2023
@afcapelafcapelforce-pushed theupdate-browser-versions branch 4 times, most recently fromd89ec5e to6a9d7b0CompareJuly 20, 2023 14:49
@afcapelafcapelforce-pushed theupdate-browser-versions branch 8 times, most recently fromc1b7456 tobed325aCompareAugust 3, 2023 10:28
@afcapelafcapelforce-pushed theupdate-browser-versions branch frombed325a tod536282CompareAugust 3, 2023 10:38
@seanpdoyle
Copy link
Collaborator

As additional data points, both#1121 and#1122 timed out after 6 hours.

I've re-forked the repository and re-opened them as#1128 and#1127 to give them a chance to re-run.

Is this branch still viable as a solution?

@seanpdoyle
Copy link
Collaborator

After more investigation, I believe the issue is that forksdo not inherit repository secrets:

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

This means that contributors submitting pull requests are executing their own suites in their own CI environments withoutaccess toSAUCE_USERNAME orSAUCE_ACCESS_KEY.

Do contributors need to register their own accounts and get their own secrets?

@afcapel
Copy link
ContributorAuthor

Do contributors need to register their own accounts and get their own secrets?

Ugh, that's quite a hurdle for contributing. Ideally we would run the tests from the GitHub actions instance ifSAUCE_KEY is not present, and use Sauce Labs only on PRs. Running the tests locally is much more reliable than CI.

But there must be something else going on. The test randomly fail some times even when theSAUCE_KEY is present. Not sure exactly why, but the error messages look like connection problems.

afcapel added a commit that referenced this pull requestFeb 2, 2024
Allows forks to run tests on GitHub Actions without having to have accessto the SauceLabs secret.Ref.#1072 (comment)
afcapel added a commit that referenced this pull requestFeb 2, 2024
Allows forks to run tests on GitHub Actions without having to have accessto the SauceLabs secret.Ref.#1072 (comment)
@afcapel
Copy link
ContributorAuthor

@seanpdoyle I've updated the CI script to only run tests on SauceLabs if it has access to anSAUCE_ACCESS_KEY.

#1130

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@afcapel@seanpdoyle

[8]ページ先頭

©2009-2025 Movatter.jp