Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Replace JUnit-style asserts with TestNG Assert in tests#44377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Better-Boy wants to merge1 commit intoballerina-platform:master
base:master
Choose a base branch
Loading
fromBetter-Boy:assert-replace

Conversation

@Better-Boy
Copy link

Purpose

Fixes ##41480

@Better-Boy
Copy link
Author

Currently, only assert statements in test files are updated. Once this is approved, I'll work on replacing assert statement in source code.

@TharmiganK@keizer619@gimantha

@Better-Boy
Copy link
Author

Better-Boy commentedOct 30, 2025•
edited
Loading

@Better-Boy
Copy link
Author

@TharmiganK /@keizer619 it's been over a week but still no review

@dulajdilshan
Copy link
Contributor

@Better-Boy

The PR title and commit messages do not follow the best practices we commonly use. Please followContribution Guidelines. Also, please check other closed PRs for a reference.

Copy link
Contributor

@dulajdilshandulajdilshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Implementation is LGTM. But please change the PR title and reword commit messages.

@Better-BoyBetter-Boy changed the titlereplace assert statements with testng Assert in test filesReplace JUnit-style asserts with TestNG Assert in testsNov 22, 2025
@Better-Boy
Copy link
Author

Implementation is LGTM. But please change the PR title and reword commit messages.

done

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dulajdilshandulajdilshandulajdilshan left review comments

@gimanthagimanthagimantha approved these changes

@MaryamZiMaryamZiAwaiting requested review from MaryamZiMaryamZi is a code owner

@azinneeraazinneeraAwaiting requested review from azinneeraazinneera is a code owner

@KavinduZoysaKavinduZoysaAwaiting requested review from KavinduZoysaKavinduZoysa is a code owner

@warunalakshithawarunalakshithaAwaiting requested review from warunalakshithawarunalakshitha is a code owner

@sameerajayasomasameerajayasomaAwaiting requested review from sameerajayasomasameerajayasoma is a code owner

@keizer619keizer619Awaiting requested review from keizer619keizer619 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Better-Boy@dulajdilshan@gimantha
[8]ページ先頭
©2009-2025 Movatter.jp