Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork10
feat(redux): dispatcher with middleware#97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
4 commits Select commitHold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
3 changes: 2 additions & 1 deletion.textlintrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletionsREADME.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletionpackage.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletionssrc/redux/Dispatcher.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // LICENSE : MIT | ||
| "use strict"; | ||
| const assert = require("assert"); | ||
| const EventEmitter = require("events"); | ||
| export const ON_DISPATCH = "__ON_DISPATCH__"; | ||
| /** | ||
| * payload The payload object that must have `type` property. | ||
| * @typedef {Object} DispatcherPayload | ||
| * @property {String} type The event type to dispatch. | ||
| * @public | ||
| */ | ||
| export default class Dispatcher extends EventEmitter { | ||
| /** | ||
| * add onAction handler and return unbind function | ||
| * @param {function(DispatcherPayload)} payloadHandler | ||
| * @returns {Function} call the function and release handler | ||
| * @public | ||
| */ | ||
| onDispatch(payloadHandler) { | ||
| this.on(ON_DISPATCH, payloadHandler); | ||
| return this.removeListener.bind(this, ON_DISPATCH, payloadHandler); | ||
| } | ||
| /** | ||
| * dispatch action object. | ||
| * StoreGroups receive this action and reduce state. | ||
| * @param {DispatcherPayload} payload | ||
| * @public | ||
| */ | ||
| dispatch(payload) { | ||
| assert(payload !== undefined && payload !== null, "payload should not null or undefined"); | ||
| assert(typeof payload.type === "string", "payload's type should be string"); | ||
| this.emit(ON_DISPATCH, payload); | ||
| } | ||
| } |
22 changes: 22 additions & 0 deletionssrc/redux/apply-middleware.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // LICENSE : MIT | ||
| "use strict"; | ||
| // core - | ||
| // next - next function | ||
| // action - action object | ||
| const applyMiddlewares = (...middlewares) => { | ||
| return middlewareAPI => { | ||
| const originalDispatch = middlewareAPI.dispatch.bind(middlewareAPI); | ||
| const wrapMiddleware = middlewares.map(middleware => { | ||
| return middleware(middlewareAPI); | ||
| }); | ||
| // apply middleware order by first | ||
| const last = wrapMiddleware[wrapMiddleware.length - 1]; | ||
| const rest = wrapMiddleware.slice(0, -1); | ||
| const roundDispatch = rest.reduceRight((oneMiddle, middleware) => { | ||
| return middleware(oneMiddle); | ||
| }, last); | ||
| return roundDispatch(originalDispatch); | ||
| }; | ||
| }; | ||
| export default applyMiddlewares; |
54 changes: 54 additions & 0 deletionstest/redux/apply-middleware-test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // LICENSE : MIT | ||
| "use strict"; | ||
| const assert = require("power-assert"); | ||
| import applyMiddleware from "../../src/redux/apply-middleware"; | ||
| import Dispatcher from "../../src/redux/Dispatcher"; | ||
| import timestamp from "../../src/redux/timestamp"; | ||
| import createLogger from "../../src/redux/logger"; | ||
| describe("middleware", function () { | ||
| it("could apply logger middleware", function () { | ||
| const dispatcher = new Dispatcher(); | ||
| const logs = []; | ||
| const con = { | ||
| log(message){ | ||
| logs.push(message); | ||
| } | ||
| }; | ||
| const middleware = createLogger({ | ||
| logger: con | ||
| }); | ||
| // state | ||
| const state = {}; | ||
| const middlewareAPI = { | ||
| getState(){ | ||
| return state; | ||
| }, | ||
| dispatch(action){ | ||
| dispatcher.dispatch(action); | ||
| } | ||
| }; | ||
| const dispatchWithMiddleware = applyMiddleware(middleware)(middlewareAPI); | ||
| const action = {type: "FOO"}; | ||
| // then | ||
| dispatcher.onDispatch(payload => { | ||
| if(payload.type === "FOO"){ | ||
| state.isUpdated = true; | ||
| } | ||
| }); | ||
| // when | ||
| dispatchWithMiddleware(action); | ||
| assert.deepEqual(logs, [action, state]); | ||
| }); | ||
| it("could apply timestamp middleware", function (done) { | ||
| const dispatcher = new Dispatcher(); | ||
| const dispatchWithMiddleware = applyMiddleware(timestamp)(dispatcher); | ||
| const action = {type: "FOO"}; | ||
| // then | ||
| dispatcher.onDispatch(payload => { | ||
| assert(typeof payload.timeStamp === "number"); | ||
| done(); | ||
| }); | ||
| // when | ||
| dispatchWithMiddleware(action); | ||
| }); | ||
| }); |
2 changes: 1 addition & 1 deletiontest/redux/timestamp-test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.