Commitf10c2e0

and

authored

fix(buildFullPath): handleallowAbsoluteUrls: false withoutbaseURL (#6833)

Co-authored-by: Jay <jasonsaayman@gmail.com>

1 parent1e6632c commitf10c2e0Copy full SHA for f10c2e0

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ import combineURLs from '../helpers/combineURLs.js';`
`15`	`15`	`*/`
`16`	`16`	`exportdefaultfunctionbuildFullPath(baseURL,requestedURL,allowAbsoluteUrls){`
`17`	`17`	`letisRelativeUrl=!isAbsoluteURL(requestedURL);`
`18`		`-if(baseURL&&isRelativeUrl\|\|allowAbsoluteUrls==false){`
	`18`	`+if(baseURL&&(isRelativeUrl\|\|allowAbsoluteUrls==false)){`
`19`	`19`	`returncombineURLs(baseURL,requestedURL);`
`20`	`20`	`}`
`21`	`21`	`returnrequestedURL;`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,10 @@ describe('helpers::buildFullPath', function () {`
`13`	`13`	`expect(buildFullPath('https://api.github.com','https://api.example.com/users',false)).toBe('https://api.github.com/https://api.example.com/users');`
`14`	`14`	`});`
`15`	`15`
	`16`	`+it('should not combine the URLs when the requestedURL is absolute, allowAbsoluteUrls is false, and the baseURL is not configured',function(){`
	`17`	`+expect(buildFullPath(undefined,'https://api.example.com/users',false)).toBe('https://api.example.com/users');`
	`18`	`+});`
	`19`	`+`
`16`	`20`	`it('should not combine URLs when the baseURL is not configured',function(){`
`17`	`21`	`expect(buildFullPath(undefined,'/users')).toBe('/users');`
`18`	`22`	`});`

Comments

(0)