aws/aws-step-functions-data-science-sdk-pythonPublic

NotificationsYou must be signed in to change notification settings
Fork89
Star292

[Feature]: Support new ASL choice comparators#88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

yoodan93 merged 5 commits intoaws:masterfromyoodan93:master

Oct 2, 2020

Merged

[Feature]: Support new ASL choice comparators#88

yoodan93 merged 5 commits intoaws:masterfromyoodan93:master

Oct 2, 2020

Conversation

Copy link

Contributor

yoodan93 commentedSep 21, 2020•
edited
Loading

Adding new choice state comparators that were added to the Amazon States Language specifications.https://states-language.net/

These include:

StringMatches
IsNull, IsPresent, IsString, IsNumeric, IsBoolean, IsTimestamp
StringEqualsPath, StringLessThanPath, StringGreaterThanPath, StringLessThanEqualsPath, StringGreaterThanEqualsPath, NumericEqualsPath, NumericLessThanPath, NumericGreaterThanPath, NumericLessThanEqualsPath, NumericGreaterThanEqualsPath, BooleanEqualsPath, TimestampEqualsPath, TimestampLessThanPath, TimestampGreaterThanPath, TimestampLessThanEqualsPath, TimestampGreaterThanEqualsPath

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[Feature]: Support new ASL choice comparators

16177d7

Copy link

Contributor

StepFunctions-Bot commentedSep 21, 2020

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository

Copy link

Contributor

StepFunctions-Bot commentedSep 22, 2020

AWS CodeBuild CI Report

CodeBuild project: StepFunctionsPythonSDK-integtests
Commit ID:16177d7
Result: FAILED
Build Logs (available for 30 days)

Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository

Merge branch 'master' into master

9518733

Copy link

Contributor

StepFunctions-Bot commentedSep 24, 2020

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository

Copy link

Contributor

StepFunctions-Bot commentedSep 24, 2020

AWS CodeBuild CI Report

CodeBuild project: StepFunctionsPythonSDK-integtests
Commit ID:9518733
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository

vaib-amz requested review fromrwwardh andvaib-amz

September 24, 2020 21:54

wong-a suggested changes

Sep 24, 2020

View reviewed changes

tests/unit/test_choice_rule.py Outdated

		withpytest.raises(ValueError):
		func('$.Variable',True)

		deftest_path_function_value_must_be_consistent():

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	deftest_path_function_value_must_be_consistent():
	deftest_path_operator_raises_error_when_value_is_not_a_path():

tests/unit/test_choice_rule.py Outdated

		withpytest.raises(ValueError):
		func('$.Variable','string')

		deftest_is_function_value_must_be_consistent():

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	deftest_is_function_value_must_be_consistent():
	deftest_is_operator_raises_error_when_value_is_not_a_bool():

src/stepfunctions/steps/choice_rule.py Outdated


		Args:
		variable (str): Path to the variable to compare.
		value (bool): Constant value to compare `variable` against.

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For the type comparisons, maybe the documentation forvalue can be more descriptive:

IsNull: "Whether the value atvariable is equal to the JSON literalnull or not.
IsPresent: "Whether a field atvariable exists in the input or not.
IsNumeric: "Whether the value atvariable is a string or not.
etc.

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fixed in subsequent commit

tests/unit/test_choice_rule.pyShow resolvedHide resolved

vaib-amz previously approved these changes

Sep 24, 2020

View reviewed changes

rwwardh previously approved these changes

Sep 24, 2020

View reviewed changes

Copy link

rwwardh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Adam mentioned some naming changes. Once done it should be good to go.

Daniel Yoo added2 commits

September 24, 2020 23:59

Add choice rule serialization test and improve choice rule documentation

bfae3d9

Merge branch 'master' of github.com:yoodan93/aws-step-functions-data-…

1f7d4e3

…science-sdk-python

yoodan93 dismissed stale reviews fromrwwardh andvaib-amz via1f7d4e3

September 25, 2020 04:00

Copy link

Contributor

StepFunctions-Bot commentedSep 25, 2020

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository

Copy link

Contributor

StepFunctions-Bot commentedSep 25, 2020

AWS CodeBuild CI Report

CodeBuild project: StepFunctionsPythonSDK-integtests
Commit ID:1f7d4e3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository

Copy link

Contributor

StepFunctions-Bot commentedSep 25, 2020

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository

Copy link

Contributor

StepFunctions-Bot commentedSep 25, 2020

AWS CodeBuild CI Report

CodeBuild project: StepFunctionsPythonSDK-integtests
Commit ID:61fff47
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository

wong-a suggested changes

Sep 25, 2020

View reviewed changes

src/stepfunctions/steps/choice_rule.py OutdatedShow resolvedHide resolved

src/stepfunctions/steps/choice_rule.py Outdated


		Args:
		variable (str): Path to the variable to compare.
		value (bool): Constant value to compare `variable` against.

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I missed this one earlier. The value forStringMatches is astr. Since this is one of the ambiguous operators, let's add a description of the format in the documentation. Customers shouldn't have to go the ASL spec to figure out how to use this SDK.

Suggested change

	value (bool):Constantvaluetocompare`variable`against.
	value (str):Astringpatternthatmaycontainoneormore``characterstocomparethevalueat`variable`to.Thecomparisonyieldstrueifthevariablematchesthepattern,where``isawildcardthatmatcheszeroormorecharacters.

Trying to think of good wording about escaping special characters with\. Not sure if there's anything that's handled differently in Python.

Copy link

Contributor

StepFunctions-Bot commentedSep 29, 2020

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository

Copy link

Contributor

StepFunctions-Bot commentedSep 29, 2020

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository

Copy link

Contributor

StepFunctions-Bot commentedSep 29, 2020

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository

wong-a previously approved these changes

Sep 29, 2020

View reviewed changes

src/stepfunctions/steps/choice_rule.py Outdated

		Args:
		variable (str): Path to the variable to compare.
		value (str): A string pattern that may contain one or more `*` characters to compare the value at `variable` to.
		The `*` character can be escaped using two backslashes.