- Notifications
You must be signed in to change notification settings - Fork89
Improve AWS service integration support (pattern)#74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AWS CodeBuild CI Report
Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository |
creatorrr commentedOct 2, 2021
Is this planned to be merged soon? PR seems a bit outdated,@FrancisLfg do you need help to update it? |
@creatorrr - this PR does seem a little stale, but we are starting to introduce integration patterns as an enum in#125 We cannot just change the properties and drop the flags to introduce the integration pattern enum as it copy@ca-nguyen |
Uh oh!
There was an error while loading.Please reload this page.
Some AWS service integration are not supported by the sdk, for instance ECS/Fargate with callback pattern :https://docs.aws.amazon.com/step-functions/latest/dg/connect-supported-services.html.
This PR improve service integration and support callback pattern for ECS/Fargate.
2 options has been removed : 'wait_for_callback' and 'wait_for_completion' and a new one has been added : 'integration_pattern'.
As we have 3 choices Request, Sync and Callback boolean option does not suit well this is why this PR adds an enum to manage the service integration pattern. So we now need to pass the wanted pattern as :
step = BatchSubmitJobStep('Batch Job', integration_pattern=IntegrationPattern.RequestResponse)where integration_pattern can take following values :
I have used documentation terminology. It is a breaking change but IMHO, the 2 options wait_for_* should not be kept.
I also refactored a bit Task class to check if pattern if supported by a given service, and to automatize
Field.Resource.valuegeneration.All unit tests are OK, I am not able to perform integ test right now but it should have no impact.
I am not sure how to test the documentation generation, what should I do to check that documentation is OK ?
Let me know if some part are not clear or if we could do better, I am not sure about the "name" and "action" Task class attribute but it helps simplifying
Field.Resource.valuevalue generation and error management, what do you think ?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.