- Notifications
You must be signed in to change notification settings - Fork89
refactor: Update AWS Glue Databrew StartJobRun step to use integration pattern input#176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Suggested changes were added in last commit
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Shiv Lakshminarayan <shivlaks@amazon.com>
| kwargs[Field.Resource.value]=get_service_integration_arn(GLUE_DATABREW_SERVICE_NAME, | ||
| GlueDataBrewApi.StartJobRun, | ||
| integration_pattern) | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nit (non-blocking): would be good to have the comment precede the Field.Resource assignment.
StepFunctions-Bot commentedNov 12, 2021
AWS CodeBuild CI Report
Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository |
Description
Update AWS Glue Databrew service integration to use
integration_patterninput instead orwait_for_completionflag.Fixes #(issue) (N/A)
Why is the change necessary?
This change is necessary for consistency with the new service integration implementation pattern introduced incommit (Add support for Nested Step Functions) that uses the
integration_patternarg in the step constructor to build the resource.Support for AWS Glue Databrew service integration was added in thiscommit, but notreleased yet.
A latercommit (Add support for Nested Step Functions) introduced a new implementation pattern using the
IntegrationPatternenum as input to construct the step instead of thewait_for_completionflag. (SeePR for more detail on rationale behind the implementation).Solution
Replace the
wait_for_completionflag withintegration_patternarg inStartJobRun step construction.The
IntegrationPatternis used to build theResourcearn as follow:SeeService Integration Patterns for more details
Normally, replacing a constructor argument would be a breaking change, but since we have not released support for AWS Glue Databrew service integration yet, it is acceptable to do so. After next release, it making such changes will be considered as not being backward compatible.
Testing
Manual Tests
Create a
Databrewjob for manual tests (<databrew_job_name>).For each test, create a workflow and execute as follow:
Pull Request Checklist
Please check all boxes (including N/A items)
Testing
Documentation
Title and description
Fixes #xxx-N/ABy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.