- Notifications
You must be signed in to change notification settings - Fork89
feat: Support placeholders for TuningStep#173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: Support placeholders for TuningStep#173
Uh oh!
There was an error while loading.Please reload this page.
Conversation
8569fa0 to5991cf8Compare5991cf8 to39640f8CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
some minor questions
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Comments were addressed and PR was updated per suggestions in the last commit
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Shiv Lakshminarayan <shivlaks@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nice! 🎉
AWS CodeBuild CI Report
Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository |
evscott left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks great! 🚀
Description
Add support to define Hyperparameters Tuning parameters dynamically using placeholders
Fixes#85
Why is the change necessary?
Currently, it is not possible to use placeholders for Sagemaker Hyperparameters Tuning properties. The properties cannot be defined dynamically, as they need to be defined in the HyperparameterTuner which does not accept placeholders.
This change makes it possible to use placeholders for HyperparameterTuner properties by using the parameters field that are passed down from the TuningStep.
Solution
Use the
parametersfield that is compatible with placeholders to define TuningStep properties.Merge the parameters that were generated from theHyperparameterTuner with the input parameters:
data- which requires RecordSets as data depending on the estimator used to define the tuner.Testing
Added unit and integration tests
Pull Request Checklist
Please check all boxes (including N/A items)
Testing
Documentation
Title and description
Fixes #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.