Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Support placeholders for TransformStep#157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ca-nguyen
Copy link
Contributor

@ca-nguyenca-nguyen commentedSep 2, 2021
edited
Loading

Description

Please include a summary of the change being made.

Fixes#117 and#171

Why is the change necessary?

Currently, it is not possible to use placeholders for Sagemaker Transform properties. The properties cannot be defined dynamically, as they need to be defined in the Transformer which does not accept placeholders.
This change makes it possible to use placeholders for Transform properties by using theparameters field that are passed down from the TransformStep.

Solution

Use theparameters field that is compatible with placeholders to define TrainingStep properties.
Merge the parameters that were generated from theTransformer with the input parameters:

  • The input parameters will overwrite the parameters generated from the Transformer if the properties were defined in both
  • All TransformStep properties will be placeholder compatible
  • The input parameters should follow the schema described inCreateTransformJob API doc

Testing

Added integration and unit tests


Pull Request Checklist

Please check all boxes (including N/A items)

Testing

  • Unit tests added
  • integration test added

Documentation

  • docs: All relevantdocs updated
  • docstrings: All public APIs documented

Title and description

  • Change type: Title is prefixed with change type: and followsconventional commits
  • References: Indicate issues fixed via:Fixes #xxx

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@ca-nguyen
Copy link
ContributorAuthor

The tests pass locally - will need more investigation for throttling issues during build

Copy link

@evscottevscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Besides the small comment typo, lgtm 🚀

shivlaks
shivlaks previously requested changesOct 5, 2021
Copy link
Contributor

@shivlaksshivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

getting close. some minor nits but otherwise looks great!

ca-nguyenand others added3 commitsOctober 15, 2021 10:26
@ca-nguyenca-nguyen dismissedshivlaks’sstale reviewOctober 15, 2021 17:45

Updated PR per suggestions and addressed comments

@StepFunctions-Bot
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-sEHrOdk7acJc
  • Commit ID:1422243
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository

@ca-nguyenca-nguyen merged commit8b6d0eb intoaws:mainOct 18, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@yuan-bwnyuan-bwnAwaiting requested review from yuan-bwn

2 more reviewers

@evscottevscottevscott approved these changes

@shivlaksshivlaksshivlaks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add placeholders support for all properties

4 participants

@ca-nguyen@StepFunctions-Bot@evscott@shivlaks

[8]ページ先頭

©2009-2025 Movatter.jp