- Notifications
You must be signed in to change notification settings - Fork89
feat: Support placeholders for TransformStep#157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: Support placeholders for TransformStep#157
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ca-nguyen commentedSep 9, 2021
The tests pass locally - will need more investigation for throttling issues during build |
Uh oh!
There was an error while loading.Please reload this page.
evscott left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Besides the small comment typo, lgtm 🚀
shivlaks left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
getting close. some minor nits but otherwise looks great!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Eliot V Scott <eliotvscott@gmail.com>Co-authored-by: Shiv Lakshminarayan <shivlaks@amazon.com>
Updated PR per suggestions and addressed comments
StepFunctions-Bot commentedOct 15, 2021
AWS CodeBuild CI Report
Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository |
Uh oh!
There was an error while loading.Please reload this page.
Description
Please include a summary of the change being made.
Fixes#117 and#171
Why is the change necessary?
Currently, it is not possible to use placeholders for Sagemaker Transform properties. The properties cannot be defined dynamically, as they need to be defined in the Transformer which does not accept placeholders.
This change makes it possible to use placeholders for Transform properties by using the
parametersfield that are passed down from the TransformStep.Solution
Use the
parametersfield that is compatible with placeholders to define TrainingStep properties.Merge the parameters that were generated from theTransformer with the input parameters:
Testing
Added integration and unit tests
Pull Request Checklist
Please check all boxes (including N/A items)
Testing
Documentation
Title and description
Fixes #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.