Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Adds support for Placeholders in TrainingStep to set S3 location for InputDataConfig and OutputDataConfig#142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ca-nguyen
Copy link
Contributor

@ca-nguyenca-nguyen commentedJun 11, 2021•
edited by shivlaks
Loading

Issue #, if available:#98,#97,#80

Description of changes:
Currently, it is not possible to specify the output path to TrainingStep. It needs to be defined at the Estimator level, which does not support placeholders. This change will make it possible to insert a placeholder output path from the TrainingStep definition and propagate it dynamically to the Estimator.

This change change also makes the TrainingStep data parameter compatible with placeholders.

There are other feature requests to make other TrainingStep arguments and ProcessingStep arguments compatible with placeholders. They will be addressed in a separate PR where the implementation could maybe be done at a higher level to avoid repetition.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ca-nguyenca-nguyen changed the titleFeature: Adding placeholder output_path parameter to TrainingStep to …[DRAFT]Feature: Adding placeholder output_path parameter to TrainingStep to …Jun 11, 2021
@ca-nguyenca-nguyen marked this pull request as ready for reviewJune 15, 2021 02:01
@ca-nguyenca-nguyen changed the title[DRAFT]Feature: Adding placeholder output_path parameter to TrainingStep to …Feature: Adding placeholder output_path parameter to TrainingStep to …Jun 15, 2021
Copy link
Contributor

@wong-awong-a left a comment•
edited by ca-nguyen
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Almost there! Remaining items:

  • Update name ofoutput_path argument to not clash with existingoutput_path forTask
  • Comment and variable naming improvements
  • Unit tests

@wong-awong-a changed the titleFeature: Adding placeholder output_path parameter to TrainingStep to …Feature: Support Placeholders in TrainingStep to set S3 location for InputDataConfig and OutputDataConfigJun 17, 2021
@ca-nguyenca-nguyen requested a review fromwong-aJune 17, 2021 21:00
@ca-nguyenca-nguyen requested a review fromwong-aJune 18, 2021 17:12

fromenumimportEnum
fromstepfunctions.inputsimportExecutionInput,StepInput
importlogging
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To be removed in next commit

@shivlaksshivlaks changed the titleFeature: Support Placeholders in TrainingStep to set S3 location for InputDataConfig and OutputDataConfigfeat: Adds support for Placeholders in TrainingStep to set S3 location for InputDataConfig and OutputDataConfigJun 19, 2021
@StepFunctions-Bot
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-sEHrOdk7acJc
  • Commit ID:7ae50d6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository

@shivlaksshivlaks merged commit764df67 intoaws:mainJun 19, 2021
shivlaks added a commit that referenced this pull requestJun 21, 2021
bump for `v2.2.0` which includes the following changes:Features* Placeholders in TrainingStep to set S3 location for InputDataConfig and OutputDataConfig (#142)* EventBridge service integration (#147)Fixes* supplying hyperparameters to training step constructor drops hyperparameters specified in estimator (#144)
@ca-nguyenca-nguyen deleted the training-step-with-dynamic-output-path branchOctober 27, 2021 01:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@yuan-bwnyuan-bwnAwaiting requested review from yuan-bwn

2 more reviewers

@shivlaksshivlaksshivlaks approved these changes

@wong-awong-awong-a approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ca-nguyen@StepFunctions-Bot@shivlaks@wong-a
[8]ページ先頭
©2009-2025 Movatter.jp