- Notifications
You must be signed in to change notification settings - Fork89
Add support for dynamic timeout and heartbeat in Task state#113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AWS CodeBuild CI Report
Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's fix the failing unit tests. Doesn't seem related to this change though.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/stepfunctions/steps/service.py Outdated
| state_id (str): State name whose length **must be** less than or equal to 128 unicode characters. State names **must be** unique within the scope of the whole state machine. | ||
| wait_for_callback(bool, optional): Boolean value set to `True` if the Task state should wait for callback to resume the operation. (default: False) | ||
| timeout_seconds (int, optional): Positive integer specifying timeout for the state in seconds. If the state runs longer than the specified timeout, then the interpreter fails the state with a `States.Timeout` Error Name. (default: 60) | ||
| timeout_seconds_path (str, optional): Path applied to the state's input to select the integer to be used for timeout seconds duration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Aren't these applicable to all Task types and not just the ones you've updated?
Co-authored-by: Adam Wong <55506708+wong-a@users.noreply.github.com>
AWS CodeBuild CI Report
Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, one comment on the docstring
src/stepfunctions/steps/states.py Outdated
| state_id (str): State name whose length **must be** less than or equal to 128 unicode characters. State names **must be** unique within the scope of the whole state machine. | ||
| resource (str): A URI that uniquely identifies the specific task to execute. The States language does not constrain the URI scheme nor any other part of the URI. | ||
| timeout_seconds (int, optional): Positive integer specifying timeout for the state in seconds. If the state runs longer than the specified timeout, then the interpreter fails the state with a `States.Timeout` Error Name. (default: 60) | ||
| timeout_seconds_path (str, optional): Path applied to the state's input to select the integer to be used for timeout seconds duration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Grammar and extra help taken from thedocs:
| timeout_seconds_path (str,optional):Pathappliedtothestate'sinputtoselecttheintegertobeusedfortimeoutsecondsduration. | |
| timeout_seconds_path (str,optional):Pathspecifyingthestate'stimeoutvalueinsecondsfromthestateinput.Whenresolved,thepathmustselectafieldwhosevalueisapositiveinteger. |
Same suggestion applies forheartbeat_seconds_path
AWS CodeBuild CI Report
Powered bygithub-codebuild-logs, available on theAWS Serverless Application Repository |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.