generated fromamazon-archives/__template_Apache-2.0
- Notifications
You must be signed in to change notification settings - Fork83
BugFix: Add support for both IPv4 and IPv6 connections#229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
sparrovv wants to merge1 commit intoaws:masterChoose a base branch fromsparrovv:ipv6
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Updated the method `__get_host_address_info` to support returning both IPv4 and IPv6 address information. - The method now returns a tuple containing the address (sockaddr) and the address family (af). - This allows the caller to handle the address appropriately based on its type.- Modified the initializer to handle both IPv4 and IPv6 addresses. - The method `__get_host_address_info` is called and its response is unpacked into `hostport` and `address_family`. - Created a socket using the correct address family (`AF_INET` for IPv4 and `AF_INET6` for IPv6). - Ensured that the socket is connected using the `hostport` which now correctly handles both address types.
Open
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
At my company we started using VPN that only works over IPv6. Since that we started seeing below errors when connecting:
Mainly played around and used chat GPT to make the above changes, so please let me know if they look fine with you.
Details
Updated the method
__get_host_address_infoto support returning both IPv4 and IPv6 address information.Modified the initializer to handle both IPv4 and IPv6 addresses.
__get_host_address_infois called and its response is unpacked intohostportandaddress_family.AF_INETfor IPv4 andAF_INET6for IPv6).hostportwhich now correctly handles both address types.Motivation and Context
Testing
I've tried to connect both on new and old VPN and this snipped doesn't return an error anymore:
Screenshots (if appropriate)
Types of changes
Checklist
./build.shsucceedspytest test/unitand they are passing.