Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/avaPublic

Replace arrgv with args-tokenizer#3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
TrySound wants to merge2 commits intoavajs:main
base:main
Choose a base branch
Loading
fromTrySound:args-tokenizer

Conversation

@TrySound
Copy link
Contributor

@TrySoundTrySound commentedDec 29, 2024•
edited
Loading

Recently published args-tokenizer package. We use it at Webstudio for parsing cURL on paste. Also used athttps://github.com/antfu-collective/bumpp.

There are a few benefits

  • published with type definitions
  • parser is forgiving to unclosed quotes which can be more user friendly
  • actively supported, arrgv last release was 5 years ago

The package also is esm only but used only in CLI so should not be a problem with commonjs. Though I can add cjs support if necessary.

https://github.com/TrySound/args-tokenizer

Recently published args-tokenizer package. We use it at Webstudio forparsing cURL on paste. Used athttps://github.com/antfu-collective/bumpp.There are two benefits- published with type definitions- parser is forgiving to unclosed quotes which can be more user friendlyThe package also is esm only but used only in CLI so should not be aproblem with commonjs. Though I can add cjs support if necessary.https://github.com/TrySound/args-tokenizer
@sindresorhus
Copy link
Member

I don't think silently forgiving invalid input is an improvement.

@TrySound
Copy link
ContributorAuthor

Will "strict" option work for you? I can add it

@TrySound
Copy link
ContributorAuthor

Upgraded to new strict by default version and reverted test changes

@novemberborn
Copy link
Member

novemberborn commentedJun 6, 2025•
edited
Loading

@TrySound apologies for ignoring this for so long. What would give more confidence is if you incorporatearrgvs test cases, that way it's easier to treat this as a like-for-like substitution. Shipping a 1.0 would also be great.

@novemberbornnovemberborn marked this pull request as draftJune 6, 2025 20:54
@novemberborn
Copy link
Member

@TrySound apologies for ignoring this for so long. What would give more confidence is if you incorporatearrgvs test cases, that way it's easier to treat this as a like-for-like substitution. Shipping a 1.0 would also be great.

To follow up on this, you're asking to replace a dependency that as far as I know hasn't caused problems with a modern version you wrote. That's great! But the less work for me to verify the behavior is exactly the same, the better.

@TrySound
Copy link
ContributorAuthor

Of course! Thanks for your response. Will update PR when release 1.0

@kensmajesty-ship-it

This comment was marked as off-topic.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TrySound@sindresorhus@novemberborn@kensmajesty-ship-it
[8]ページ先頭
©2009-2025 Movatter.jp