NotificationsYou must be signed in to change notification settings
Fork50
Star165

Muxing silent audio channels#304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

valnoel merged 8 commits intoavTranscoder:developfromvalnoel:muxing_silent_audio_channels

Sep 28, 2017

Merged

Muxing silent audio channels#304

valnoel merged 8 commits intoavTranscoder:developfromvalnoel:muxing_silent_audio_channels

Sep 28, 2017

Conversation

Copy link

Member

valnoel commentedSep 21, 2017•
edited
Loading

The idea of this PR is to enable muxing of generated streams into a multichannel output stream.
To indicate we want to generate such a channel, we can now create one or moreInputStreamDesc with empty filename, and add it to the input sources of aTranscoder. A generator will be used as channel source.
However, we cannot generate an output stream will only generated channels with this method, since we can useTranscoder::addGenerateStream() method with the corresponding output profile.
But for instance, we can now create a 5.1 audio stream with a silent LFE channel.

Valentin NOEL added7 commits

September 21, 2017 14:52

StreamTranscoder: add null input stream to generate output channel

55a4bab

If the InputStreamDesc filename is empty, a generator is set up as input

StreamTranscoder: manage process case according to the input index

dd89b56

Transcoder: handle empty filnames only case

4d4ca1e

StreamTranscoder: store the index of the first non-null input stream

28dc5fe

Instead of using the getFirstInputStreamIndex() private method.

StreamTranscoder: throw an exception if no non-null InputStream is se…

a85f867

…t as inputUser should use the StreamTranscoder(IOutputFile&, constProfileLoader::Profile&) constructor to handle this case.

Transcoder: throw an exception if no non-empty filename is set as input

cc755ba

Since the input profile cannot be guessed from such inputs.

Tests: add silent audio channels muxing tests

c609ac8

Copy link

coveralls commentedSep 21, 2017

Coverage decreased (-0.02%) to 78.661% when pullingc609ac8 on valnoel:muxing_silent_audio_channels intod33ffd2 on avTranscoder:develop.

1 similar comment

Copy link

coveralls commentedSep 21, 2017•
edited
Loading

Coverage decreased (-0.02%) to 78.661% when pullingc609ac8 on valnoel:muxing_silent_audio_channels intod33ffd2 on avTranscoder:develop.

InputStreamDesc: add a few documentation

d834fe3

valnoel changed the title~~[WIP] Muxing silent audio channels~~Muxing silent audio channels

Sep 22, 2017

valnoel assignedcchampet

Sep 22, 2017

Copy link