NotificationsYou must be signed in to change notification settings
Fork50
Star165

Add analyse level full#291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

valnoel merged 19 commits intoavTranscoder:developfromcchampet:addAnalyseLevelFull

Nov 23, 2016

Merged

Add analyse level full#291

valnoel merged 19 commits intoavTranscoder:developfromcchampet:addAnalyseLevelFull

Nov 23, 2016

Conversation

Copy link

Member

cchampet commentedNov 21, 2016•
edited
Loading

I compiled ffmpeg-2.7.7 and avTranscoder in release mode without any specific options, and I get 1min of process to decode and compute all the properties (bitrate, duration, nbFrames) of an AVC stream of 3min (stored in local).

Clement Champetier added2 commits

November 2, 2016 18:44

file: add eAnalyseLevelFull level

dffb65a

VideoProperties: add analyseFull private method which decodes all the…

525f0aa

… streamAnd compute the exact number of frames.

cchampet added the 2 - Working label

Nov 21, 2016

Clement Champetier added13 commits

November 21, 2016 11:58

Merge branch 'develop' ofhttps://github.com/avTranscoder/avTranscoder…

8861e17

…into addAnalyseLevelFull

VideoProperties: fix compilation since updates of VideoFrameDesc

16aafd0

VideoProperties: analyseGopStructure returns nb decoded frames

c33fb0f

VideoProperties: fix nb decoded frames in analyseFull method

ac763ff

Use the number of decoded frames in analyseGopStructure method.

VideoProperties: refactor seek to the beginning of the file after ana…

465af95

…lysis

VideoProperties: add progress callback in analyseFull method

b112ba8

VideoProperties: update log when estimate bitrate / duration

604d7a8

VideoProperties: refactor how to return the number of frames

eb7442d

* Add log.* Avoid complicate if/else...

VideoProperties: in case of full analysis get the exact duration

b6978bc

From the number of frames and the fps.

VideoProperties: add log when no need to decode all the stream in cas…

b01356f

…e of full analysis

VideoProperties: fix progress of full analysis

b977583

The current frame is already decoded when we call the callback.

pyTest: add a test to check full analysis of a raw video stream

d853c8c

avMeta: use eAnalyseLevelFull level

7f1077f

And show the progress.

cchampet assignedvalnoel

Nov 21, 2016

Copy link

coveralls commentedNov 21, 2016•
edited
Loading

Coverage increased (+0.1%) to 78.273% when pullingd853c8c on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

2 similar comments

Copy link

coveralls commentedNov 21, 2016

Coverage increased (+0.1%) to 78.273% when pullingd853c8c on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

Copy link

coveralls commentedNov 21, 2016

Coverage increased (+0.1%) to 78.273% when pullingd853c8c on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

Copy link

coveralls commentedNov 21, 2016•
edited
Loading

Coverage increased (+0.1%) to 78.273% when pulling7f1077f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

2 similar comments

Copy link

coveralls commentedNov 21, 2016

Coverage increased (+0.1%) to 78.273% when pulling7f1077f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

Copy link

coveralls commentedNov 21, 2016

Coverage increased (+0.1%) to 78.273% when pulling7f1077f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

cchampet changed the title~~[WIP] Add analyse level full~~Add analyse level full

Nov 22, 2016

VideoProperties: add const to local variables of getNbFrames

84fc4bf

Copy link

coveralls commentedNov 22, 2016•
edited
Loading

Coverage increased (+0.1%) to 78.273% when pulling84fc4bf on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

2 similar comments

Copy link

coveralls commentedNov 22, 2016

Coverage increased (+0.1%) to 78.273% when pulling84fc4bf on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

Copy link

coveralls commentedNov 22, 2016

Coverage increased (+0.1%) to 78.273% when pulling84fc4bf on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

valnoel reviewed

Nov 22, 2016

View reviewed changes

src/AvTranscoder/properties/VideoProperties.cpp

		VideoFrame frame(VideoFrameDesc(getWidth(), getHeight(), getPixelFormatName(getPixelProperties().getAVPixelFormat())), false);

		_nbFrames = nbDecodedFrames;

Copy link

Member

valnoelNov 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does this have a real sense to set the number of images with the GOP image number?

src/AvTranscoder/properties/VideoProperties.cpp


		// Returns at the beginning of the stream
		const_cast<InputFile&>(_fileProperties->getInputFile()).seekAtFrame(0, AVSEEK_FLAG_BYTE);
		}

Copy link

Member

valnoelNov 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Shouldn't we use a switch statement here? We might have thisconst_cast<InputFile&>(_fileProperties->getInputFile()).seekAtFrame(0, AVSEEK_FLAG_BYTE); line twice, but it could be clearer, don't you think?

Copy link

MemberAuthor

cchampetNov 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Something like that?ad44be7

src/AvTranscoder/properties/VideoProperties.cpp

		LOG_INFO("Need a deeper analysis: see eAnalyseLevelFirstGop.")
		return 0;
		}
		else

Copy link

Member

valnoelNov 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not necessary! :)

Copy link

MemberAuthor

cchampetNov 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Humm... I think it is ;)

Copy link

Member

valnoelNov 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it is not!

Copy link

MemberAuthor

cchampetNov 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

a61d95f :)

Copy link

Member

valnoelNov 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Well, you changed it into thegetDuration() method, but not into thisgetNbFrames()!

Copy link

MemberAuthor

cchampetNov 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"Et voilà"0f7508f :)

src/AvTranscoder/properties/VideoProperties.cpp

		LOG_INFO("Need a deeper analysis: see eAnalyseLevelFirstGop.")
		return 0;
		}
		else

Copy link

Member

valnoelNov 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not necessary too!

VideoProperties: refactor how to launch deeper analysis

ad44be7

Use a switch statement instead of several if.

VideoProperties: refactor how to getDuration

a61d95f

Else statement was not necessary!

Copy link

coveralls commentedNov 23, 2016•
edited
Loading

Coverage increased (+0.1%) to 78.267% when pullinga61d95f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

5 similar comments

Copy link

coveralls commentedNov 23, 2016

Coverage increased (+0.1%) to 78.267% when pullinga61d95f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

Copy link

coveralls commentedNov 23, 2016

Coverage increased (+0.1%) to 78.267% when pullinga61d95f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

Copy link

coveralls commentedNov 23, 2016

Coverage increased (+0.1%) to 78.267% when pullinga61d95f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

Copy link

coveralls commentedNov 23, 2016

Coverage increased (+0.1%) to 78.267% when pullinga61d95f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

Copy link

coveralls commentedNov 23, 2016

Coverage increased (+0.1%) to 78.267% when pullinga61d95f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

Copy link

coveralls commentedNov 23, 2016•
edited
Loading

Coverage increased (+0.1%) to 78.267% when pullinga61d95f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

2 similar comments

Copy link

coveralls commentedNov 23, 2016

Coverage increased (+0.1%) to 78.267% when pullinga61d95f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

Copy link

coveralls commentedNov 23, 2016

Coverage increased (+0.1%) to 78.267% when pullinga61d95f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

VideoProperties: refactor how to getNbFrames

0f7508f

Else statement was not necessary!

Copy link

coveralls commentedNov 23, 2016

Coverage increased (+0.1%) to 78.267% when pulling0f7508f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

4 similar comments

Copy link

coveralls commentedNov 23, 2016

Coverage increased (+0.1%) to 78.267% when pulling0f7508f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

Copy link

coveralls commentedNov 23, 2016

Coverage increased (+0.1%) to 78.267% when pulling0f7508f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

Copy link

coveralls commentedNov 23, 2016

Coverage increased (+0.1%) to 78.267% when pulling0f7508f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

Copy link

coveralls commentedNov 23, 2016

Coverage increased (+0.1%) to 78.267% when pulling0f7508f on cchampet:addAnalyseLevelFull intocbb248b on avTranscoder:develop.

valnoel merged commit244f417 intoavTranscoder:develop

Nov 23, 2016

cchampet removed the 2 - Working label

Nov 23, 2016

Labels

None yet

3 participants

Movatterモバイル変換

Add analyse level full#291

Add analyse level full#291

Uh oh!

Conversation

cchampet commentedNov 21, 2016• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

coveralls commentedNov 21, 2016• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

coveralls commentedNov 21, 2016

Uh oh!

coveralls commentedNov 21, 2016

Uh oh!

coveralls commentedNov 21, 2016• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

coveralls commentedNov 21, 2016

Uh oh!

coveralls commentedNov 21, 2016

Uh oh!

coveralls commentedNov 22, 2016• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

coveralls commentedNov 22, 2016

Uh oh!

coveralls commentedNov 22, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commentedNov 23, 2016• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

coveralls commentedNov 23, 2016

Uh oh!

coveralls commentedNov 23, 2016

Uh oh!

coveralls commentedNov 23, 2016

Uh oh!

coveralls commentedNov 23, 2016

Uh oh!

coveralls commentedNov 23, 2016

Uh oh!

coveralls commentedNov 23, 2016• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

coveralls commentedNov 23, 2016

Uh oh!

coveralls commentedNov 23, 2016

Uh oh!

coveralls commentedNov 23, 2016

Uh oh!

coveralls commentedNov 23, 2016

Uh oh!

coveralls commentedNov 23, 2016

Uh oh!

coveralls commentedNov 23, 2016

Uh oh!

coveralls commentedNov 23, 2016

Uh oh!

Uh oh!

cchampet commentedNov 21, 2016•
edited
Loading

coveralls commentedNov 21, 2016•
edited
Loading

coveralls commentedNov 21, 2016•
edited
Loading

coveralls commentedNov 22, 2016•
edited
Loading

coveralls commentedNov 23, 2016•
edited
Loading

coveralls commentedNov 23, 2016•
edited
Loading