- Notifications
You must be signed in to change notification settings - Fork50
CMake: remove patch version in the avtranscoder library name on Windows#288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
CMake: remove patch version in the avtranscoder library name on Windows#288
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* avtranscoder-0.11.0 becomes avtranscoder-0.11* avtranscoder-java-0.11.0 becomes avtranscoder-java-0.11
71385bc toc6744c1Comparecoveralls commentedNov 7, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
1 similar comment
coveralls commentedNov 7, 2016
coveralls commentedNov 7, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
| @@ -154,7 +154,7 @@ if(SWIG_FOUND) | |||
| # Create 'avtranscoder-java' shared lib | |||
| swig_add_module(avtranscoder-java java ${AVTRANSCODER_BINDING_FILE}) | |||
| if(WIN32) | |||
| set_target_properties(avtranscoder-java PROPERTIES OUTPUT_NAME "avtranscoder-java-${AVTRANSCODER_VERSION}") | |||
| set_target_properties(avtranscoder-java PROPERTIES OUTPUT_NAME "avtranscoder-java-${AVTRANSCODER_VERSION_MAJOR}-${AVTRANSCODER_VERSION_MINOR}") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The generated JAR name should be changed too, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes you are right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Arg it does not seems to be a good idea, since widely used Java tools, like Maven, expects Jar namednameJar-fullVersion.jar. We need to take some time to discuss about this possible update...
Uh oh!
There was an error while loading.Please reload this page.
Goal: avtranscoder is a based library for lot of other intern projects. We should be able to patch avtranscoder without recompile all our other projects based on it.