- Notifications
You must be signed in to change notification settings - Fork50
Dummy stream: new way to add#28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
cchampet commentedJul 21, 2014
- Add EssenceDesc (based class of VideoDesc and AudioDesc).
- Transcoder: 2 new "add(...)" functions.
- Refactoring (add const).
* AudioDesc and VideoDesc inherit EssenceDesc.* Rename getAudio/VideoCodec to getCodec.* Rename setAudio/VideoCodec to setCodec.* remove unused includes.
* Use "const ProfileDesc" instead of "ProfileDesc" when instanciate aStreamTranscoder.* Consequences: * OutputAudio: setProfile with a const ProfileDesc. * OutputVideo: setProfile with a const ProfileDesc. * use find instead of [] to access the elements of ProfileDesc.
* 2 new "add(...)" functions, the only ones which can create dummystreams (from a profileDesc and an EssenceDesc). When the user tries tocreate a dummy stream with an empty file name and no EssenceDescindicated, there is no add.* Update comments to fit to this new behavior.
* Use "const EssenceDesc" instead of "EssenceDesc" when add aDummyStream.* Consequences: * AudioDesc: copy constructor with const EssenceDesc. * VideoDesc: copy constructor with const EssenceDesc. * DummyVideo: setVideoDesc from a const VideoDesc (already the casefor setAudioDesc in DummyAudio).
MarcAntoine-Arnaud added a commit that referenced this pull requestJul 21, 2014
Dummy stream: new way to add
cchampet pushed a commit to cchampet/avTranscoder that referenced this pull requestDec 29, 2014
Up to CMake 2.8.11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.