NotificationsYou must be signed in to change notification settings
Fork50
Star165

Commitc619856

Clement Champetier

committed

VideoProperties: return fps as a float type

Double type is not constructed the same way in C++ and Java, and doesnot exist in python. Our bindings of 'C++ double' could create issues,and since a fps with a simple precision is enough, we decided to returnfps as float.

1 parentcda8459 commitc619856Copy full SHA for c619856

File tree

2 files changed

-4

lines changed

src/AvTranscoder/mediaProperty
- VideoProperties.cpp
- VideoProperties.hpp

2 files changed

-4

lines changed

`‎src/AvTranscoder/mediaProperty/VideoProperties.cpp`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -518,9 +518,9 @@ int VideoProperties::getLevel() const`
`518`	`518`	`return _codecContext->level;`
`519`	`519`	`}`
`520`	`520`
`521`		`-doubleVideoProperties::getFps()const`
	`521`	`+floatVideoProperties::getFps()const`
`522`	`522`	`{`
`523`		`-size_t nbFrames =getNbFrames();`
	`523`	`+constsize_t nbFrames =getNbFrames();`
`524`	`524`	`if( nbFrames )`
`525`	`525`	`{`
`526`	`526`	`double duration =getDuration();`
`@@ -531,7 +531,7 @@ double VideoProperties::getFps() const`
`531`	`531`
`532`	`532`	`// if nbFrames of stream is unknwon`
`533`	`533`	`Rational timeBase =getTimeBase();`
`534`		`-double fps = timeBase.den / (double) timeBase.num;`
	`534`	`+float fps = timeBase.den / (double) timeBase.num;`
`535`	`535`	`if(std::isinf( fps ) )`
`536`	`536`	`{`
`537`	`537`	`std::ostringstream os;`

`‎src/AvTranscoder/mediaProperty/VideoProperties.hpp`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ class AvExport VideoProperties : public StreamProperties`
`56`	`56`	`intgetProfile()const;`
`57`	`57`	`intgetLevel()const;`
`58`	`58`
`59`		`-doublegetFps()const;`
	`59`	`+floatgetFps()const;`
`60`	`60`
`61`	`61`	`boolhasBFrames()const;`
`62`	`62`	`//bool isClosedGop() const;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc619856

File tree

2 files changed

2 files changed

`‎src/AvTranscoder/mediaProperty/VideoProperties.cpp`

`‎src/AvTranscoder/mediaProperty/VideoProperties.hpp`

0 commit comments