Commit2e0fde3

committed

Fix: video filters support and audio filters memory leak

Free video filters data at each process loop, but skip audio filtersdata frame.Improvement ofbe100b8 fix

1 parentaf4c609 commit2e0fde3Copy full SHA for 2e0fde3

File tree

-6

lines changed

-6

lines changed

Lines changed: 9 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -751,12 +751,6 @@ IOutputStream::EWrappingStatus StreamTranscoder::processTranscode()`
`751`	`751`	`_transformedData->allocateData();`
`752`	`752`	`}`
`753`	`753`	`}`
`754`		`-elseif(_filterGraph->hasFilters())`
`755`		`- {`
`756`		`-LOG_DEBUG("Free filtered data")// filled from filter graph sink`
`757`		`-av_frame_unref(&_filteredData->getAVFrame());`
`758`		`- _filteredData->freeData();`
`759`		`- }`
`760`	`754`
`761`	`755`	`// Check decoding status`
`762`	`756`	`bool continueProcess =true;`
`@@ -811,6 +805,15 @@ IOutputStream::EWrappingStatus StreamTranscoder::processTranscode()`
`811`	`805`	`LOG_DEBUG("Encode")`
`812`	`806`	`_outputEncoder->encodeFrame(*_transformedData, data);`
`813`	`807`
	`808`	`+if(_filterGraph->hasFilters())`
	`809`	`+ {`
	`810`	`+LOG_DEBUG("Free filtered data")// filled from filter graph sink`
	`811`	`+if (_filteredData->isVideoFrame()) {`
	`812`	`+// Do not unref filter audio frame, to avoid reallocating it each time`
	`813`	`+av_frame_unref(&_filteredData->getAVFrame());`
	`814`	`+ }`
	`815`	`+ _filteredData->freeData();`
	`816`	`+ }`
`814`	`817`	`}`
`815`	`818`	`else`
`816`	`819`	`{`

Comments

(0)