Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add variant exclusion per-project in DSL#1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
joshfriend wants to merge1 commit intoautonomousapps:main
base:main
Choose a base branch
Loading
fromjoshfriend:exclude-variants

Conversation

joshfriend
Copy link
Contributor

We have a lot offake/demo/testing style projects that are only intended for consumption by debug variant apps. Some of these have onlydebug/ sourcesets. In a perfect world, we would use single-variant android libraries and rely on other tooling to ensure these projects never end up in release builds. Our current state leaves us with a lot of complications if we try to run analysis on both debug and release variants because these debug-only projects often fail to compile in the release configuration, or we are just wasting time by analyzingreleaseUnitTest stuff.

I'd propose this as an intermediate solution until a v3.0 where we might have a more advanced DSL for exclusions. What I'd really like to do is be able to exclude release variants for test source sets everywhere.

Copy link
Owner

@autonomousappsautonomousapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why is this on the AbiHandler? The way it's used, it looks like it's causing the variant to be ignored for all use-cases, not just ABI analysis. And given that, why isn't the existing functionality toignore specific source sets sufficient?

@joshfriend
Copy link
ContributorAuthor

Why is this on the AbiHandler?

I got it mixed up with theProjectIssueHandler handler, what I was going for was a project specific version of the global propertydependency.analysis.android.ignored.variants that exists currently.

why isn't the existing functionality toignore specific source sets sufficient?

If I have an Android project with only adebug/ source set, and I useignoreSourceSet('release') DAGP still compiles and analyzes the variant (or it tries to and fails because the release configuration of some of these debug-only projects is often broken).

@joshfriendjoshfriend marked this pull request as draftMay 29, 2025 01:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@autonomousappsautonomousappsautonomousapps left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@joshfriend@autonomousapps

[8]ページ先頭

©2009-2025 Movatter.jp