- Notifications
You must be signed in to change notification settings - Fork23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix: added agent name to client.create calls to prevent runtime loggi…#47
Conversation
The multimodal part looks good to me, but I am not sure about the client side. If we can pass the test cases, I think it should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, let's see the test cases.
Okay, have tested both and they are working. Thanks@LaraNonino! I can pytest the |
@LaraNonino thanks for your contribution. Are you on Discord? I'd like to follow up and acknowledge your contribution there. |
Thank you for taking time to review it and merging. I reached out on discord. |
* replace Event to CloudEvent WIP* switch to CloudEvents* dapr implementation WIP* fix namespaces and dapr sdk weirdness* WIP* dapr support WIP* dapr WIP* dapr WIP* dapr semi-working implementation* fix mapping bug* dapr reminders in sandbox* fix prompts* merge almost done* switch to Newtnsoft serialization for Marketing* add event surogate for Orleans serialization* remove newtnsoft serialization (not needed)* cleanup appsettings in marketing sample
Fix: added agent name to client.create calls to prevent runtime logging error (microsoft#3507)
client.createcall inmultimodal_conversable_agent.pyby addingagent=self.nameas a parameter.client.createcall insociety_of_mind_agent.pywithagent=self.name.These changes ensure that the agent's name is passed correctly, preventing the
NoneTypeerror during runtime logging inMultimodalConversableAgent.