- Notifications
You must be signed in to change notification settings - Fork23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Use utf-8 encoding at subprocess.run()#23
Conversation
@Hk669 - when I run the sample code, without the proposed code-base changes, it doesn't throw an exception for me. So I'm guessing this dependent on the environment it is run in.
I have tried inside my docker container and outside and I can't replicate the issue, so I assume it's environmental. Have you been able to replicate the crash? |
@marklysze I believe it's with the windows. But let me run on my machine and let you know about this. |
Thanks, I tested on Ubuntu |
![]() it doesn't work on windows without this fix. cc@sonichi |
Added first overview for the FAQ, please check.. also on spelling and grammar and correctness of the content.
Why are these changes needed?
This fix is picked from the msft main repo.
as this is a small 2 line fix, we are not requesting the contributor to make a new PR here.
Related issue number
Checks