Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Use utf-8 encoding at subprocess.run()#23

Merged
qingyun-wu merged 5 commits intomainfromfix-autogen
Sep 6, 2024
Merged

Conversation

Hk669
Copy link
Collaborator

Why are these changes needed?

This fix is picked from the msft main repo.
as this is a small 2 line fix, we are not requesting the contributor to make a new PR here.

Related issue number

Checks

@marklysze
Copy link
Collaborator

marklysze commentedSep 3, 2024
edited
Loading

@Hk669 - when I run the sample code, without the proposed code-base changes, it doesn't throw an exception for me. So I'm guessing this dependent on the environment it is run in.

user_proxy (to assistant):Run the following code snippet: `print('Καλημέρα')`--------------------------------------------------------------------------------assistant (to user_proxy):To run the provided code snippet, you can save it in a Python file and then execute it. Here is the complete code:python# filename: greet.pyprint('Καλημέρα')Save the above code in a file named `greet.py` and then run it using the following shell command:shpython greet.pyThis will print "Καλημέρα" (which means "Good morning" in Greek) to the console. Please execute the above steps and let me know the result.-------------------------------------------------------------------------------->>>>>>>> EXECUTING 2 CODE BLOCKS (inferred languages are [python, sh])...user_proxy (to assistant):exitcode: 0 (execution succeeded)Code output: 0.00s - Debugger warning: It seems that frozen modules are being used, which may0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off0.00s - to python to disable frozen modules.0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.ΚαλημέραΚαλημέρα--------------------------------------------------------------------------------assistant (to user_proxy):The code executed successfully and printed "Καλημέρα" as expected. The additional output regarding the debugger warning is not related to the functionality of the code itself.Everything seems to be in order. If you have any other tasks or questions, feel free to ask.TERMINATE-------------------------------------------------------------------------------

I have tried inside my docker container and outside and I can't replicate the issue, so I assume it's environmental.

Have you been able to replicate the crash?

@Hk669
Copy link
CollaboratorAuthor

Hk669 commentedSep 4, 2024
edited
Loading

@marklysze I believe it's with the windows. But let me run on my machine and let you know about this.

marklysze reacted with thumbs up emoji

@marklysze
Copy link
Collaborator

@marklysze I believe it's with the windows. But let me run on my machine and let you know about this.

Thanks, I tested on Ubuntu

Hk669 reacted with thumbs up emoji

@Hk669
Copy link
CollaboratorAuthor

image

it doesn't work on windows without this fix.

cc@sonichi

@qingyun-wuqingyun-wu merged commitc1ee997 intomainSep 6, 2024
150 of 153 checks passed
@qingyun-wuqingyun-wu deleted the fix-autogen branchSeptember 6, 2024 14:29
odoochain pushed a commit to odoochain/autogen that referenced this pull requestNov 10, 2024
Added first overview for the FAQ, please check.. also on spelling and grammar and correctness of the content.
odoochain pushed a commit to odoochain/autogen that referenced this pull requestNov 10, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@marklyszemarklyszeAwaiting requested review from marklysze

@qingyun-wuqingyun-wuAwaiting requested review from qingyun-wu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@Hk669@marklysze@sonichi@qingyun-wu

[8]ページ先頭

©2009-2025 Movatter.jp