Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Include pending tests for bugfix related to Kafka messages with UUID record keys#699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
omkar-shitole wants to merge5 commits intoauthorjapps:master
base:master
Choose a base branch
Loading
fromomkar-shitole:bugfix-kafka-messages-with-record-keys

Conversation

@omkar-shitole
Copy link
Collaborator

@omkar-shitoleomkar-shitole commentedFeb 11, 2025
edited
Loading

Fixes Issue

PR Branch
#https://github.com/omkar-shitole/zerocode/tree/bugfix-kafka-messages-with-record-keys

Motivation and Context

Based on thediscussion at the time of closing Issue#557, here are some basic test cases that address edge cases related to object types and UUID keys.
These tests could be useful for future development if any changes occur in the relevant classes, ensuring a smooth flow for handling UUIDs and object keys.
This PR replaces PR#681 (previously closed without merge).

Checklist:

  • New Unit tests were added

    • Covered in existing Unit tests
  • Integration tests were added

    • Covered in existing Integration tests
  • Test names are meaningful

  • Feature manually tested and outcome is successful

  • PR doesn't break any of the earlier features for end users

    • WARNING! This might break one or more earlier earlier features, hence left a comment tagging all reviewrs
  • Branch build passed in CI

  • No 'package.*' in the imports

  • Relevant Documentation page added or updated with clear instructions and examples for the end user

    • Not applicable. This was only a code refactor change, no functional or behaviourial changes were introduced
  • Http test added tohttp-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added tokafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nirmalchandranirmalchandraAwaiting requested review from nirmalchandra

@authorjappsauthorjappsAwaiting requested review from authorjapps

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@omkar-shitole

[8]ページ先頭

©2009-2025 Movatter.jp