Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed flaky test-case: ZeroCodeAssertionsProcessorImplTest#testDate.testDateAfterBefore_fail_both#691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
hermya wants to merge2 commits intoauthorjapps:master
base:master
Choose a base branch
Loading
fromhermya:fix-flaky

Conversation

@hermya
Copy link
Contributor

Fixed flaky test-case

Fixes Issue

PR Branch
fork

Motivation and Context

ZeroCodeAssertionsProcessorImplTest#testDate.testDateAfterBefore_fail_both is a flaky test, fixed in this PR.

POINT OF FAILURE ->

InZeroCodeAssertionsProcessorImpl.createJsonAsserters,ObjectMapper.mapTree creates aJsonNode object whose key-value pairs are not necessarily ordered, thus the elements inList<JsonAsserter> are not ordered, causing further failures.
Fixed using NonDex pugin

For particular test:
Add the following lines to your pom.xml

  <plugin> <!-- for flaky testing -->      <groupId>edu.illinois</groupId>      <artifactId>nondex-maven-plugin</artifactId>      <version>2.1.7</version>  </plugin>

and run

mvn -pl ./core nondex:nondex -Dtest=org.jsmart.zerocode.core.engine.preprocessor.ZeroCodeAssertionsProcessorImplTest#testDateAfterBefore_fail_both -DnondexRuns=10 -DnondexMode=ONE

OR

mvn -pl ./core edu.illinois:nondex-maven-plugin:2.1.7:nondex -Dtest=org.jsmart.zerocode.core.engine.preprocessor.ZeroCodeAssertionsProcessorImplTest#testDateAfterBefore_fail_both -DnondexRuns=10 -DnondexMode=ONE

For more information :https://github.com/TestingResearchIllinois/NonDex

Checklist:

  • New Unit tests were added

    • Covered in existing Unit tests
  • Integration tests were added

    • Covered in existing Integration tests
  • Test names are meaningful

  • Feature manually tested and outcome is successful

  • PR doesn't break any of the earlier features for end users

    • WARNING! This might break one or more earlier earlier features, hence left a comment tagging all reviewrs
  • Branch build passed in CI

  • No 'package.*' in the imports

  • Relevant DOcumentation page added or updated with clear instructions and examples for the end user

    • Not applicable. This was only a code refactor change, no functional or behaviourial changes were introduced
  • Http test added tohttp-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added tokafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hermya

[8]ページ先頭

©2009-2025 Movatter.jp