Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork442
Fixed flaky test-case: ZeroCodeAssertionsProcessorImplTest#testDate.testDateAfterBefore_fail_both#691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
hermya wants to merge2 commits intoauthorjapps:masterChoose a base branch fromhermya:fix-flaky
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…AfterBefore_fail_both
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed flaky test-case
Fixes Issue
The following issue is similar to the PR in context
Flaky tests detected: ConsumerJsonRecordTest.should_serialize_a_record_with_headers #685
PR Branch
fork
Motivation and Context
ZeroCodeAssertionsProcessorImplTest#testDate.testDateAfterBefore_fail_bothis a flaky test, fixed in this PR.POINT OF FAILURE ->
In
ZeroCodeAssertionsProcessorImpl.createJsonAsserters,ObjectMapper.mapTreecreates aJsonNodeobject whose key-value pairs are not necessarily ordered, thus the elements inList<JsonAsserter>are not ordered, causing further failures.Fixed using NonDex pugin
For particular test:
Add the following lines to your pom.xml
and run
OR
For more information :https://github.com/TestingResearchIllinois/NonDex
Checklist:
New Unit tests were added
Integration tests were added
Test names are meaningful
Feature manually tested and outcome is successful
PR doesn't break any of the earlier features for end users
Branch build passed in CI
No 'package.*' in the imports
Relevant DOcumentation page added or updated with clear instructions and examples for the end user
Http test added to
http-testingmodule(if applicable) ?Kafka test added to
kafka-testingmodule(if applicable) ?