- Notifications
You must be signed in to change notification settings - Fork73
⬆️ draft support for laravel 6.*#53
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fec06d3 tob7e4ae7CompareSigned-off-by: Wim <wim@join.marketing>
roelofr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nothing really has changed. Are there any breaking changes so far?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| @@ -63,7 +63,7 @@ directory. The most logical place to start are the [docs for the `HasEncryptedAt | |||
| ## Requirements | |||
| * Laravel: 5.5, 5.6, 5.7,or5.8 | |||
| * Laravel: 5.5, 5.6, 5.7, 5.8, or 6.x | |||
| * PHP: 7.1, 7.2, or 7.3 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since 7.1 isalready deprecated and 7.2 is in security-only, maybe also look into PHP 7.4 support (addallow-failure CI tests for example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, That's good idea. For now I was just looking into my own case where i needed Laravel 6 and php 7.3 support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think that should be a separate PR. There will probably be some issues.
Co-Authored-By: Roelof <github@roelof.io>
Thats right, everything seems to work fine so far, it's just the CI tests that i didn't get to succeed, because of the above dependency issues |
Co-Authored-By: Roelof <github@roelof.io>
- Don't double-install packages. Add new packages first and pull them all in at the same time.- Removed uopz. It's not being used.- Use `composer test`, which allows us to add additional tests there.
roelofr commentedDec 13, 2019
I had some suggestions, so I opened these in aPull Request on your fork. |
Improved Laravel 6 Support
leoneparise commentedJan 28, 2020
When will it be merged? I would like to use this lib on Laravel 6 without using my own repo. |
| * @param int $value | ||
| * @return string|null | ||
| */ | ||
| function str_random(int $value = 16): ?string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why? Just replace it withIlluminate\Support\Str::random() if it's even being used anywhere.
roelofr commentedJan 28, 2020
Seconding this, I hope@austinheap has some time to look at this. |
leoneparise commentedJan 31, 2020
Thanks@roelofr. Looking forward for next release. |
dcnl1980 commentedFeb 6, 2020
Any idea when it will be merged? |
emielmolenaar commentedMar 3, 2020
A merge would be awesome :) |
RobertCordes commentedMar 18, 2020
@emielmolenaar Yeah, especially since Laravel 7 is already live. |
roelofr commentedMar 18, 2020
Well, a major release every half year is something entirely different compared to the minor releases we had before. |
potofcoffee commentedMay 20, 2020
Could you please merge this? This is the only thing keeping me back on Laravel 5.8 |
zeboe commentedOct 16, 2020
Any more news on this one already? In need of the 6 version as well. |
Signed-off-by: Wimwim@join.marketing