This repository was archived by the owner on Dec 15, 2022. It is now read-only.

atom/language-pythonPublic archive

NotificationsYou must be signed in to change notification settings
Fork147
Star191

Update tree-sitter-python + Add missing tree-sitter scopes#325

Merged

darangi merged 14 commits intoatom:masterfromaminya:master

Jan 27, 2021

Merged

Update tree-sitter-python + Add missing tree-sitter scopes#325

darangi merged 14 commits intoatom:masterfromaminya:master

Jan 27, 2021

Conversation

Copy link

Contributor

aminya commentedOct 28, 2020•
edited
Loading

Description of the Change

This updates tree-sitter python dependency.

Benefits

Bug fixes:tree-sitter/tree-sitter-python@v0.15.1...v0.17.0

Applicable Issues

Solves some of the open issues regarding syntax highlighting.

Fixes#324
Fixes#134
Fixes#273
Fixes#312

Allows removing the Kite's workaround for tree-sitter:
https://github.com/kiteco/atom-plugin/pull/704

⬆️ Update tree-sitter-python

faf1e57

aminya changed the title~~⬆️ Update tree-sitter-python~~Update tree-sitter-python

Oct 28, 2020

Update Travis linux distro

ad4b980

aminya mentioned this pull request

Nov 21, 2020

GitHub Actionsatom/language-java#238

Open

⬆️ bump tree-sitter-python to 0.17.0

ebe8830

Copy link

ContributorAuthor

aminya commentedJan 8, 2021

@sadick254 @darangi Please take a look.

aminyaand others added5 commits

January 8, 2021 11:59

Add keyword.control.return

d989f9a

Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

Add punctuations

c2b79f1

Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

Use function.def for function_definition

6325ed1

Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

Use function.call for call

89351c1

Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

Support constructor

b0a77d5

Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

aminya changed the title~~Update tree-sitter-python~~Update tree-sitter-python + Add missing tree-sitter scopes

Jan 8, 2021

aminyaand others added3 commits

January 8, 2021 12:15

Support lambda parameters

37c8e1d

Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

Support typed parameters

98cab19

Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

Support self matching

6e5de57

Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

aminya mentioned this pull request

Jan 8, 2021

Matching method calltree-sitter/tree-sitter-python#96

Closed

Support argument list

4d96607

tree-sitter/tree-sitter-python#96

jeff-hykin reviewed

Jan 8, 2021

View reviewed changes

grammars/tree-sitter-python.cson OutdatedShow resolvedHide resolved

use entity.name.function.definition

5d54870

Copy link

chbk commentedJan 12, 2021

As a heads-up,#313 also fixes the missing scopes mentioned here. That said, it's part of a larger ecosystem of PRs that might take time to (hopefully) get merged, so I'm glad to see this fixed now.

Copy link

ContributorAuthor

aminya commentedJan 12, 2021•
edited
Loading

As a heads-up,#313 also fixes the missing scopes mentioned here. That said, it's part of a larger ecosystem of PRs that might take time to (hopefully) get merged, so I'm glad to see this fixed now.

Thanks for the PR. I only need a few of these commits in my PR so I can close many things here and there. If you can rebase after me, that would be great.

cc:@sadick254

Copy link

Contributor

ThatXliner commentedJan 15, 2021•
edited
Loading

What’s the status on this? Because once this is merged, kite should also merge the “remove workaround” (a.k.a. Stop it nagging me). Then I get to enjoy performing :atom: atom 😎

Copy link

ContributorAuthor

aminya commentedJan 15, 2021

This is ready to go. We are awaiting one of the maintainers to merge this.
@sadick254 @darangi

Copy link

Contributor

ThatXliner commentedJan 18, 2021

@jeff-hykin (the reviewer)

Copy link

jeff-hykin commentedJan 18, 2021

@ThatXliner Not sure why I'm reviewer, but I added a review 😁

darangi added under-review and removed under-review labels

Jan 18, 2021

Copy link

Contributor

darangi commentedJan 18, 2021

Thanks@aminya , We will look into this

darangi added the triaged label

Jan 18, 2021

Copy link

Contributor

darangi commentedJan 27, 2021

@aminya could you resolve this conflict so I merge this in? Thanks for your contributions 🙇🏾

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This needs ^(self)\\b otherwise it'll match the self inselfserve and other things

grammars/tree-sitter-python.cson

		'default_parameter > identifier:nth-child(0)':'variable.parameter.function'
		'keyword_argument > identifier:nth-child(0)':'variable.parameter.function'
		'lambda_parameters > identifier':'variable.parameter.function'
		'typed_parameter > identifier':'variable.parameter.function'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure why.function is on there (aren't parameters always part of a function?)

Copy link

jeff-hykin commentedFeb 13, 2021•
edited
Loading

(😬 I was cleaning out my notifications and realized I commented "but I added a review" without clicking "submit" on my review)

Copy link

ContributorAuthor

aminya commentedFeb 13, 2021

Thanks for the review. Do you want to make a PR to fix these?

Copy link

jeff-hykin commentedFeb 13, 2021•
edited
Loading

The first comment should probably be a PR, although that edgecase bug I'm describing probably happens other places too. Its a really common bug with a very very small edgecase. The other comment was just clarification.

MdAbulHossain1 reviewed

Jan 17, 2022

View reviewed changes

Copy link

MdAbulHossain1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@aminya

Labels

triaged

6 participants

		'^(BaseException\|Exception\|TypeError\|StopAsyncIteration\|StopIteration\|ImportError\|ModuleNotFoundError\|OSError\|ConnectionError\|BrokenPipeError\|ConnectionAbortedError\|ConnectionRefusedError\|ConnectionResetError\|BlockingIOError\|ChildProcessError\|FileExistsError\|FileNotFoundError\|IsADirectoryError\|NotADirectoryError\|InterruptedError\|PermissionError\|ProcessLookupError\|TimeoutError\|EOFError\|RuntimeError\|RecursionError\|NotImplementedError\|NameError\|UnboundLocalError\|AttributeError\|SyntaxError\|IndentationError\|TabError\|LookupError\|IndexError\|KeyError\|ValueError\|UnicodeError\|UnicodeEncodeError\|UnicodeDecodeError\|UnicodeTranslateError\|AssertionError\|ArithmeticError\|FloatingPointError\|OverflowError\|ZeroDivisionError\|SystemError\|ReferenceError\|BufferError\|MemoryError\|Warning\|UserWarning\|DeprecationWarning\|PendingDeprecationWarning\|SyntaxWarning\|RuntimeWarning\|FutureWarning\|ImportWarning\|UnicodeWarning\|BytesWarning\|ResourceWarning\|GeneratorExit\|SystemExit\|KeyboardInterrupt)$'
		scopes:'support.type.exception'}
		scopes:'support.type.exception'},
		{match:'^(self)',scopes:'entity.name.variable.self'}

Movatterモバイル変換

Update tree-sitter-python + Add missing tree-sitter scopes#325

Update tree-sitter-python + Add missing tree-sitter scopes#325

Uh oh!

Conversation

aminya commentedOct 28, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Description of the Change

Benefits

Applicable Issues

Uh oh!

aminya commentedJan 8, 2021

Uh oh!

Uh oh!

chbk commentedJan 12, 2021

Uh oh!

aminya commentedJan 12, 2021• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

ThatXliner commentedJan 15, 2021• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

aminya commentedJan 15, 2021

Uh oh!

ThatXliner commentedJan 18, 2021

Uh oh!

jeff-hykin commentedJan 18, 2021

Uh oh!

darangi commentedJan 18, 2021

Uh oh!

darangi commentedJan 27, 2021

Uh oh!

aminya commentedJan 27, 2021

Uh oh!

jeff-hykinJan 18, 2021

Choose a reason for hiding this comment

Uh oh!

jeff-hykinJan 18, 2021

Choose a reason for hiding this comment

Uh oh!

jeff-hykin commentedFeb 13, 2021• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

aminya commentedFeb 13, 2021

Uh oh!

jeff-hykin commentedFeb 13, 2021• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

MdAbulHossain1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aminya commentedOct 28, 2020•
edited
Loading

aminya commentedJan 12, 2021•
edited
Loading

ThatXliner commentedJan 15, 2021•
edited
Loading

jeff-hykin commentedFeb 13, 2021•
edited
Loading

jeff-hykin commentedFeb 13, 2021•
edited
Loading