Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
/language-phpPublic archive

Detect nullable types in phpdoc#445

Merged
darangi merged 2 commits intoatom:masterfromBladeMF:phpdoc-nullable-types
Jan 13, 2022
Merged

Detect nullable types in phpdoc#445

darangi merged 2 commits intoatom:masterfromBladeMF:phpdoc-nullable-types
Jan 13, 2022

Conversation

BladeMF
Copy link
Contributor

Description of the Change

Allow the following syntaxes in phpdoc:

/** * @param ?int description */
/** * @param ?int|?Class description */
/** * @param ?int[] description */

Alternate Designs

I am not aware of any other alternatives.

Benefits

Allow the new nullable type syntax.

Possible Drawbacks

Not aware of any drawbacks. The change is minor.

Applicable Issues

That is a step towards solving the needin this issue.

Note

That is my first pull request to this repo. It's purpose is to be something small that will allow me to learn how to do effective PRs here - learn the rules and pracices, set up the tooling.

My main goal is to ultimately add detection for:

  • Psalm complex array types
  • PHPStan comments (@phpstan-ignore-line)
  • PHPUnit attributes (@test,@dataProvider, etc.)

@KapitanOczywisty
Copy link
Contributor

@sadick254 this PR is ready to be merged :)

@darangi
Copy link
Contributor

Thanks for the contribution 🙇🏾@BladeMF

KapitanOczywisty reacted with hooray emoji

@darangidarangi merged commit1aa8ddc intoatom:masterJan 13, 2022
@BladeMF
Copy link
ContributorAuthor

Thanks! More contributions incoming then :-)

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
1 more reviewer

@KapitanOczywistyKapitanOczywistyKapitanOczywisty approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@BladeMF@KapitanOczywisty@darangi

[8]ページ先頭

©2009-2025 Movatter.jp