This repository was archived by the owner on Dec 15, 2022. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork126
Detect nullable types in phpdoc#445
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
KapitanOczywisty suggested changesDec 25, 2021
Uh oh!
There was an error while loading.Please reload this page.
KapitanOczywisty approved these changesDec 26, 2021
@sadick254 this PR is ready to be merged :) |
Thanks for the contribution 🙇🏾@BladeMF |
Thanks! More contributions incoming then :-) |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Allow the following syntaxes in phpdoc:
Alternate Designs
I am not aware of any other alternatives.
Benefits
Allow the new nullable type syntax.
Possible Drawbacks
Not aware of any drawbacks. The change is minor.
Applicable Issues
That is a step towards solving the needin this issue.
Note
That is my first pull request to this repo. It's purpose is to be something small that will allow me to learn how to do effective PRs here - learn the rules and pracices, set up the tooling.
My main goal is to ultimately add detection for: