This repository was archived by the owner on Dec 15, 2022. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork126
limit allowed characters to UTF-8 range (0x10FFFF)#444
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
KapitanOczywisty approved these changesOct 21, 2021
@sadick254 This is ready to be merged. Other PRs could introduce more |
@IonBazan could you take a look at the conflicts? |
@darangi fixed 😉 |
Thanks for the contribution@IonBazan 🙇🏾 |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Requirements
This change limits valid characters recognized to 0x10FFFF according to UTF-8 specification.
Description of the Change
This is to make the regular expressions PCRE-compliant, where matched characters should not fall out of UTF-8 bounds:https://www.pcre.org/original/doc/html/pcreunicode.html
Since UTF-8 is a standard encoding for PHP files according toPSR-1, I don't see a point supporting any invalid Unicode characters.
Alternate Designs
Benefits
The reason for this change is actually to make GitHub Linguist support this grammar as it sticks to strict PCRE rules.
Before
After
Possible Drawbacks
Any invalid character will stop being recognized as a variable name but that shouldn't occur in real world.
Applicable Issues
github-linguist/linguist#5522
While awaiting for workflow run approval, let me just confirm that tests are passing locally.