This repository was archived by the owner on Dec 15, 2022. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork126
Attributes#405
Merged
Merged
Attributes#405
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
'begin':'''(?ix) | ||
(?: | ||
(?:^|(?<=}))\\s*(?:(abstract|final)\\s+)?(class)\\s+([a-z_\\x{7f}-\\x{7fffffff}][a-z0-9_\\x{7f}-\\x{7fffffff}]*) | ||
\\b(?:(abstract|final)\\s+)?(class)\\s+([a-z_\\x{7f}-\\x{7fffffff}][a-z0-9_\\x{7f}-\\x{7fffffff}]*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've removed complicated look-behind. As far I'm concerned, there is no case where this could backfire, but I could be wrong.
@sadick254 ready for review 😃 |
sadick254 approved these changesDec 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks great 👍
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is implementation of Attributes added in PHP 8.0. However documentation for this feature is rather bad, so I'd advice you to use sth likehttps://3v4l.org/ to determinate how this feature really works.
Implemented:
#[MyAttribute]
#[MyAttribute(true)]
#[MyAttribute(name:'Bob')]
#[\Ye\Old\Attribute]
#[A,B,C]
new #[MyAttribute] class {}
, also it's valid to writenew#[MyAttribute]class{}
Attribute
as class name, for use as argument#[Attribute(Attribute::TARGET_CLASS)]
Scopes
meta.attribute.php
for whole#[....]
support.attribute.php
for attribute name, w/ namespace scopes like in classessupport.attribute.builtin.php
forAttribute
and future builtinsNot implemented