Hmm, is there no similar fix for language-less like the one you did for language-sass? I'd like to preserve support forcursor:auto if possible.

@50Wliu Without doing a full rewrite of language-less, I don't think so. The structure of less and sass grammars is wildly different unfortunately.

That said, I think this fix would have also likely fixed the issue in language-sass without the need to change anything.

I'd like to preserve support forcursor:auto if possible.

What is wrong withcursor: auto? Is there any difference?

Is there any difference?

No difference, however I'd like to support both methods if possible.

This PR broke anautocomplete-css test. Might anyone here know the fix?

CSS property name and value autocompletions  SASS files    pseudo selectors      it CSS property name and value autocompletions SASS files pseudo selectors autocompletes without a prefix        TypeError: Cannot read property 'length' of null          at jasmine.Spec.<anonymous> (/Users/runner/work/1/s/node_modules/autocomplete-css/spec/provider-spec.coffee:903:28)          at jasmine.Spec.args.<computed> (/Users/runner/work/1/s/spec/jasmine-test-runner.coffee:89:27)

Here's the failing line of the test inautocomplete-css:https://github.com/atom/autocomplete-css/blob/v0.17.5/spec/provider-spec.coffee#L903

The issue is that the test'sgetCompletions() function returnsnull now, during that test. It's trying to find a completion near the cursor, "without a prefix", whatever that means. (This apparently only happens in this one test, only withSASS files. All other types of CSS, whether it beCSS orSCSS orLESS are all still passing.) Sorry I can't be more helpful.

(Atom's CI fails with the latestlanguage-css 0.44.5, due to this PR. I did CI runs of Atom, one with the latestlanguage-css 0.44.5, and one that was the same but with this PR reverted. Reverting this PR made the tests pass again.CI link with 0.44.5 (failing),CI link (reverted this PR, passing)).

This test failure is currently blocking thelanguage-css upgrade in Atom:atom/atom#21963 (comment)

This pull request actually caused autocompletions to stop happening for element pseudo-selectors in.sass files.

Steps to reproduce:

For example, when typingdiv: in a.sass file in Atom...

Expected:

Pseudo-selectors such asdiv::before should be automatically suggested.

Actual:

Instead, there are no autocompletion suggestions at all until you type another character, for example if you start typing another colon, it works:div:: it suggests things likediv::after. Or if you typediv:a it suggests things likediv:active. (But it should have started suggesting auto-completions with only one colon i.e.div:.)

(Thus, the failing test inautocomplete-css is a legitimate test failure, not an incorrectly coded test.)

Note: pseudo-selectors work as intended in.css and.scss files. So... I assume there must be something uniquely wrong (or simply incompatible with this PR) inthe SASS grammar... Or this PR is wrong and should be reverted? I wish I understood the language grammar files or I might try to fix this issue myself.