- Notifications
You must be signed in to change notification settings - Fork406
update os matrix in ci#2683
Uh oh!
There was an error while loading.Please reload this page.
Conversation
which is currently `ubuntu-18.05`
oh wait, I accidentally did ubuntu instead of macOS |
Would it be worthwhile to do both? |
No idea what's going on with Actions here. It looks like all of the jobs are being instantly cancelled... ? |
icecream17 commentedMay 14, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
Yeah, I just saw the Actions outage right after I posted that, heh. I'll re-run once it's resolved to see how this does 🤞🏻 |
codecovbot commentedMay 14, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #2683 +/- ##==========================================- Coverage 93.46% 93.46% -0.01%========================================== Files 237 237 Lines 13213 13213 Branches 1900 1900 ==========================================- Hits 12350 12349 -1- Misses 863 864 +1
Continue to review full report at Codecov.
|
Alright, progress 👍🏻 The failure message on Windows makes me wonder if the Windows images have been changed to already include the build tools:
The Ubuntu errors are more odd:
These tests do rely on subprocess communication and have been flaky in the past, but neverthis flaky. I would worry a bit more that these are finding an actual bug (with newer Ubuntu versions maybe) but it isn't clear to me what that could be. |
Let's merge this as-is to getsome kind of green in our CI 😅 . |
which is currently
ubuntu-18.05
See#2681 (comment)