- Notifications
You must be signed in to change notification settings - Fork406
Update shell.openExternal to promise due to electron update on atom#2625
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedFeb 11, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #2625 +/- ##==========================================+ Coverage 93.45% 93.46% +0.01%========================================== Files 237 237 Lines 13234 13215 -19 Branches 1906 1900 -6 ==========================================- Hits 12368 12352 -16+ Misses 866 863 -3
Continue to review full report at Codecov.
|
ecf308b tod08bb7bCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hmm CodeCov is complaining about these... they must not be covered by existing tests. I think that's probably not worth addressing here, though, because these methods don't do anything but call two other functions that we'd need to stub anyway.
Uh oh!
There was an error while loading.Please reload this page.
Looks like we'll need to update the stubbing in some tests, too. |
5e165e6 to9678921Compare9678921 to4ab44f3CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
✨
| it('calls shell.openExternal with specified url',asyncfunction(){ | ||
| constwrapper=shallow(buildApp()); | ||
| sinon.stub(shell,'openExternal').callsArg(2); | ||
| sinon.stub(shell,'openExternal').callsFake(()=>{}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think these could also be.returns(Promise.resolve()). No big deal though.
Requirements
Description of the Change
There are some Electron APIs that changed to only return Promises (and not run callbacks passed to them), mostly as of Electron 7+. Updating to be compatible with those would be great for updating Atom's Electron version.
Screenshot or Gif
Applicable Issues
#2624