Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: move executor to async-global-executo#867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Keruspe
Copy link
Member

@KeruspeKeruspe commentedAug 28, 2020•
edited
Loading

Based on#866

This uses async-executor under the hood and is highly inspired by both smol and the async-executor implementation inside of async-std.

Pros:

  • less code inside async-std, simpler integration
  • shares the same executors with any other users of async-global-executor
  • allows spawning local tasks on all of the global executor threads

Cons:

  • adds one more extra dependency
  • ???

@yoshuawuyts
Copy link
Contributor

Hi, thanks for this PR!

I def see how sharing the global executor between projects could be useful. But in order to accept this PR I'd like to see:

  1. async-global-executor dual licensed as MIT / Apache-2.0. If ever need to migrate away fromasync-global-executor we shouldn't need to worry about licensing questions.
  2. Granting commit/publish access to@dignifiedquire,@stjepang or myself. Or moving the project to theasync-rs org. That way if something ever needs fixing that is time-critical and for some reason we can't reach you, we're still able to move ahead.

I hope that makes sense. Thanks heaps!

@Keruspe
Copy link
MemberAuthor

Done and Done.

I'm fine with moving it to async-rs too if you see fit

yoshuawuyts and Fishrock123 reacted with heart emoji

@Keruspe
Copy link
MemberAuthor

Rebased on top of the 1.0 bumps

@dignifiedquire
Copy link
Member

Thanks. I was out for the last two weeks, will be back in the next days and take a look at this.

@Keruspe
Copy link
MemberAuthor

Rebased

@Keruspe
Copy link
MemberAuthor

CI failure should now be fixed with async-executor 1.1.1

Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Copy link
Member

@dignifiedquiredignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks fine to me, given that this is pretty much still the same code, but in a different place for now. I do like having it extracted as its own crate.
Thanks

@dignifiedquiredignifiedquire changed the titleRFC: switch to async-global-executorfeat: move executor to async-global-executoSep 15, 2020
@dignifiedquiredignifiedquire merged commit352c54b intoasync-rs:masterSep 15, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dignifiedquiredignifiedquiredignifiedquire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Keruspe@yoshuawuyts@dignifiedquire
[8]ページ先頭
©2009-2025 Movatter.jp