Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix wasm and nostd builds#863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dignifiedquire merged 13 commits intomasterfromfix-wasm
Sep 14, 2020
Merged

fix wasm and nostd builds#863

dignifiedquire merged 13 commits intomasterfromfix-wasm
Sep 14, 2020

Conversation

dignifiedquire
Copy link
Member

Closes#861,#843

tomaka reacted with rocket emoji
@dignifiedquire
Copy link
MemberAuthor

@jbr@yoshuawuyts any ideas about the CI issues, they are quite odd. Suddenly there are missing crates Oo, seems like a CI bug, as this works fine locally.

@jbr
Copy link
Contributor

jbr commentedAug 24, 2020

Agreed that it seems to be a CI issue, but I don't think it's related to this PR. See CI failures athttps://github.com/async-rs/async-std/pull/853/checks?check_run_id=988260537

Maybe it's related to caching? Does it help to temporarily comment out L32-48 of ci.yml?

@jbr
Copy link
Contributor

jbr commentedAug 25, 2020

@dignifiedquire See the above PR for a possible long-term solution to the wasm/no-std problem, but at the cost of requiring all wasm users to enable awasm feature, which would be a breaking change. I have no idea how to get both no-std and wasm compiling simultaneously without that, though, and don't understand how it ever worked

@Fishrock123
Copy link
Member

This seems fine to me, although me and@jbr were discussing with@yoshuawuyts last week and Yosh noted that just getting it to build may not be enough and actual was builds could still have issues when run in their environments.

I'm not so invested in that personally but is something that may be good to track, both for async-std and http-rs.

@dignifiedquiredignifiedquire changed the titleFix wasmfix wasm and nostd buildsSep 14, 2020
@dignifiedquiredignifiedquire merged commite9cb238 intomasterSep 14, 2020
@dignifiedquiredignifiedquire deleted the fix-wasm branchSeptember 14, 2020 19:31
@dignifiedquire
Copy link
MemberAuthor

yes we need to run the tests as well, I had wasm-bindgen-test working at some point on my machine, but forgot the magical invocations..

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@yoshuawuytsyoshuawuytsyoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI check for wasm isn't working
4 participants
@dignifiedquire@jbr@Fishrock123@yoshuawuyts

[8]ページ先頭

©2009-2025 Movatter.jp