NotificationsYou must be signed in to change notification settings
Fork341
Star4k

Some functions in future module to no_std#696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

k-nasa wants to merge4 commits intoasync-rs:main

base:main

Choose a base branch

fromk-nasa:to_no_std_future_module

Open

Some functions in future module to no_std#696

k-nasa wants to merge4 commits intoasync-rs:mainfromk-nasa:to_no_std_future_module

Conversation

Copy link

Member

k-nasa commentedFeb 4, 2020•
edited
Loading

Some functions in future module to no_std

k-nasa added4 commits

February 4, 2020 19:04

feat: to no_std future::pending

da23d16

feat: no to_std future::poll_fn

94a6ff3

feat: to no_std future::ready

3b9c7f0

feat: to no_std future module

3883079

k-nasa force-pushed theto_no_std_future_module branch froma7eaa87 to3883079Compare

February 4, 2020 10:05

k-nasa marked this pull request as ready for review

February 4, 2020 10:06

k-nasa assignedk-nasa and unassignedk-nasa

Feb 5, 2020

yjhmelody reviewed

Feb 6, 2020

View reviewed changes

src/future/poll_fn.rsShow resolvedHide resolved

k-nasa requested a review fromyoshuawuyts

March 3, 2020 14:20

yoshuawuyts reviewed

Mar 6, 2020

View reviewed changes

src/future/poll_fn.rs

		@@ -23,15 +23,18 @@ use crate::task::{Context, Poll};
		/// #
		/// # })
		/// ```
		pubasyncfn poll_fn<F, T>(f: F) ->T
		pub fn poll_fn<F, T>(f: F) ->PollFn<F>

Copy link

Contributor

yoshuawuytsMar 6, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hmm, I'm so-so about this change. Functions such asio::copy don't work on no-std either, but would be really useful to have as well. Having these functions beasync fn was a bit of a deliberate choice when designing async-std.

Withasync await for embedded rust steadily progressing, I wonder how needed this is. It seems as async/await continues to move beyond mvp status this will be much of a non-issue.

All in all I think it'd be okay to leave these methods as-is for now. Thanks!

Copy link

Collaborator

skadeMar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hm, the feature won't make the cut in 6 days, so it's at least 18 weeks out. Given that this is no user-visible change, I'd be fine with enabling embrio users to use this currently.