Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(stream): add send guards on collect#665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dignifiedquire merged 4 commits intomasterfromcollect-fix-send
Jun 27, 2020

Conversation

yoshuawuyts
Copy link
Contributor

WIP towards fixing#639. This currently doesn't work yet; needs further investigation. Thanks!

@dignifiedquire
Copy link
Member

@stjepang any chance you could help with this. This is blocking me from using Streams insidetask::spawn at the moment. I have tried, but failed to understand theextension_trait macro, which I believe needs to be modified in order to add theSend bound onfn collect

@dignifiedquiredignifiedquire changed the titleattempt to fix Send guards on collectFix Send guards on collectJun 27, 2020
@dignifiedquiredignifiedquire marked this pull request as ready for reviewJune 27, 2020 14:14
Copy link
ContributorAuthor

@yoshuawuytsyoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@dignifiedquiredignifiedquire changed the titleFix Send guards on collectfix(stream): add send guards on collectJun 27, 2020
@dignifiedquiredignifiedquire merged commitc82b1ef intomasterJun 27, 2020
@dignifiedquiredignifiedquire deleted the collect-fix-send branchJune 27, 2020 14:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@yoshuawuyts@dignifiedquire
[8]ページ先頭
©2009-2025 Movatter.jp