- Notifications
You must be signed in to change notification settings - Fork341
Add io write by_ref#525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
yoshuawuyts commentedNov 14, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I tried doing this as part of#314 a while ago. I think the right way to go about this is to add the methods to the futures-rs implementations so they can be directly targeted. I think this could indeed be considered a breaking change if we merged it here directly. My guess is we wouldn't break too much, but there's no harm in leaning a bit more on the conservative side here. |
Uh oh!
There was an error while loading.Please reload this page.
#131
Maybe it's a break change, because WriteExt and ReadExt both have by_ref.