Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add io write by_ref#525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
yjhmelody wants to merge2 commits intoasync-rs:main
base:main
Choose a base branch
Loading
fromyjhmelody:io-write-by_ref

Conversation

yjhmelody
Copy link
Contributor

@yjhmelodyyjhmelody commentedNov 13, 2019
edited
Loading

#131
Maybe it's a break change, because WriteExt and ReadExt both have by_ref.

@yoshuawuyts
Copy link
Contributor

yoshuawuyts commentedNov 14, 2019
edited
Loading

I tried doing this as part of#314 a while ago. I think the right way to go about this is to add the methods to the futures-rs implementations so they can be directly targeted.

I think this could indeed be considered a breaking change if we merged it here directly. My guess is we wouldn't break too much, but there's no harm in leaning a bit more on the conservative side here.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@yjhmelody@yoshuawuyts

[8]ページ先頭

©2009-2025 Movatter.jp