- Notifications
You must be signed in to change notification settings - Fork1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add test case foruv python list downloads#12381
Draft
zanieb wants to merge7 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
zanieb commentedMar 21, 2025
crates/uv/tests/it/python_list.rs Outdated
| let context: TestContext = TestContext::new_with_versions(&[]).with_filtered_python_keys(); | ||
| // We show all interpreters | ||
| uv_snapshot!(context.filters(), context.python_list().env_remove("UV_PYTHON_DOWNLOADS"), @r" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This might not actually be cross-platform. Testing in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's not, so we'll filter to a subset of Python versions on top of#12375
Interesting, both Linux and Windows have a couple 3.7 versions |
ad689e3 toe403ad1Comparee403ad1 toa27c93eComparecharliermarsh approved these changesMar 21, 2025
zanieb added a commit that referenced this pull requestMar 23, 2025
Allows `uv python list <request>` to filter the installed list. I oftenwant this and it's not hard to add.I tested the remote download filtering locally (#12381 is needed forsnapshot tests)```❯ cargo run -q -- python list --all-versions 3.13cpython-3.13.2-macos-aarch64-none <download available>cpython-3.13.1-macos-aarch64-none /opt/homebrew/opt/python@3.13/bin/python3.13 -> ../Frameworks/Python.framework/Versions/3.13/bin/python3.13cpython-3.13.1-macos-aarch64-none <download available>cpython-3.13.0-macos-aarch64-none /Users/zb/.local/share/uv/python/cpython-3.13.0-macos-aarch64-none/bin/python3.13❯ cargo run -q -- python list --all-versions 3.13 --only-installedcpython-3.13.1-macos-aarch64-none /opt/homebrew/opt/python@3.13/bin/python3.13 -> ../Frameworks/Python.framework/Versions/3.13/bin/python3.13cpython-3.13.0-macos-aarch64-none /Users/zb/.local/share/uv/python/cpython-3.13.0-macos-aarch64-none/bin/python3.13```
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires#12380
Extends new tests from#12374
Is waiting for dependent PRs to merge; for early review seea27c93e