Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Try a theory in CI: -fvisibility=hidden doesn't do anything#735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
geofft wants to merge1 commit intoastral-sh:main
base:main
Choose a base branch
Loading
fromgeofft:hidden

Conversation

@geofft
Copy link
Collaborator

What matters is -Wl,--exclude-libs=ALL for all of our shared objects, of which in the current commit there is only python and libpython, which already uses it.

What matters is -Wl,--exclude-libs=ALL for all of our shared objects, ofwhich in the current commit there is only python and libpython, whichalready uses it.
@geofftgeofft added platform:darwinSpecific to the macOS platform platform:linuxSpecific to the Linux platform python:3.9 python:3.13 labelsAug 8, 2025
geofft added a commit that referenced this pull requestAug 8, 2025
In general, if libX.so depends on libY.a, we don't want libY's symbolsdynamically exported by libX. We want libX's use of libY to be private.We use two mechanisms for making this happen. -fvisibility=hidden, whichworks on the build of libY to mark the symbols themselves as hidden inthe object file, and -Wl,--exclude-libs=ALL, which works on the build oflibX to instruct the linker not to re-export symbols from staticlibraries.We set -fvisibility=hidden on some platforms but not all. We use-Wl,--exclude-libs=ALL on the build of Python itself on all platforms,which up to this point built our only dynamic objects (bin/python andlibpython). Now that libtcl and libtk are dynamic, we need to do thesame thing.I'm not sure if -fvisibility=hidden actually does anything useful forus, given the use of -Wl,--exclude-libs=ALL, and I think the fact thatit's only set on some platforms is an oversight and demonstrates thatit's not needed. See#735, which removes it; the builds pass vaildation.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

platform:darwinSpecific to the macOS platformplatform:linuxSpecific to the Linux platformpython:3.9python:3.13

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@geofft

[8]ページ先頭

©2009-2025 Movatter.jp