Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update to 3.14.0b1#610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zanieb merged 15 commits intomainfromzb/14b1
Jun 4, 2025
Merged

Update to 3.14.0b1#610

zanieb merged 15 commits intomainfromzb/14b1
Jun 4, 2025

Conversation

@zanieb
@zaniebzanieb marked this pull request as draftMay 17, 2025 02:13
@zaniebzanieb changed the titleUpdate to 3.14b1Update to 3.14.0b1May 17, 2025
@zanieb
Copy link
MemberAuthor

A couple new extension modules

2025-05-17T02:24:39.4965485Z Traceback (most recent call last):2025-05-17T02:24:39.5035664Z   File "/home/runner/work/python-build-standalone/python-build-standalone/cpython-unix/build.py", line 1307, in <module>2025-05-17T02:24:39.5036416Z     sys.exit(main())2025-05-17T02:24:39.5036632Z              ^^^^^^2025-05-17T02:24:39.5037103Z   File "/home/runner/work/python-build-standalone/python-build-standalone/cpython-unix/build.py", line 1289, in main2025-05-17T02:24:39.5037637Z     build_cpython(2025-05-17T02:24:39.5038102Z   File "/home/runner/work/python-build-standalone/python-build-standalone/cpython-unix/build.py", line 764, in build_cpython2025-05-17T02:24:39.5038589Z     setup = derive_setup_local(2025-05-17T02:24:39.5038823Z             ^^^^^^^^^^^^^^^^^^^2025-05-17T02:24:39.5039313Z   File "/home/runner/work/python-build-standalone/python-build-standalone/pythonbuild/cpython.py", line 388, in derive_setup_local2025-05-17T02:24:39.5039811Z     raise Exception(2025-05-17T02:24:39.5040120Z Exception: missing extension modules from YAML: _remote_debugging, _zstd

Base automatically changed fromzb/14a7 tomainMay 17, 2025 03:37
@zaniebzaniebforce-pushed thezb/14b1 branch 5 times, most recently from8e5c165 to185c89bCompareMay 17, 2025 20:26
@zanieb
Copy link
MemberAuthor

Alright, now we need to setup zstd

cpython-3.14> make: *** No rule to make target `Modules/_zstd/zdict.c', needed by `Modules/_zstd/zdict.o'.  Stop.cpython-3.14> make: *** Waiting for unfinished jobs....cpython-3.14> In file included from ./Modules/_zstd/_zstdmodule.c:10:cpython-3.14> ./Modules/_zstd/_zstdmodule.h:11:10: fatal error: 'zstd.h' file not foundcpython-3.14>    11 | #include "zstd.h"cpython-3.14>       |          ^~~~~~~~cpython-3.14> 1 error generated.cpython-3.14> make: *** [Modules/_zstd/_zstdmodule.o] Error 1cpython-3.14> 1 warning generated.

@cclauss
Copy link
Contributor

Beta 2:https://www.python.org/downloads/release/python-3140b2/

geofft and samypr100 reacted with laugh emoji

@geofft
Copy link
Collaborator

geofft commentedMay 30, 2025
edited
Loading

Linux builds should hopefully be good now, if that validation change did what I expected.

Mac builds are failing because patch-jit-cflags-314.patch in#544 doesn't quite apply to b1 - Zanie, I'll let you handle that (and maybe you want to try b2 at the same time). If you rebase this branch on top of main, note that867ca9c revertsfab9ad2,b01c183, and856ce7e so personally I would ditch all four commits.

@zanieb
Copy link
MemberAuthor

Thanks! I'll look at that patch

@zanieb
Copy link
MemberAuthor

Windows failing due to some zstd stuff, e.g.:

cpython>          C:\Users\runneradmin\AppData\Local\Temp\python-build-pg4chnf6\Python-3.14.0b1\externals\zstd-1.5.7\lib\dictBuilder\cover.c(1,1): error C1083: Cannot open source file: 'C:\Users\runneradmin\AppData\Local\Temp\python-build-pg4chnf6\Python-3.14.0b1\externals\zstd-1.5.7\lib\dictBuilder\cover.c': No such file or directory [C:\Users\RUNNER~1\AppData\Local\Temp\python-build-pg4chnf6\Python-3.14.0b1\PCbuild\_zstd.vcxproj]

# Do not enable on x86-64 macOS because the JIT requires macOS 11+ and we are currently
# using 10.15 as a miniumum version.
if ["${TARGET_TRIPLE}"!="x86_64-apple-darwin" ];then
# Do not enable when free-threading, because they're not compatible yet.
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This just "didn't work" in previous releases, now they made it a hard error.


# ./configure tries to auto-detect whether it can build 128-bit and 256-bit SIMD helpers for HACL,
# but on x86-64 that requires v2 and v3 respectively, and on arm64 the performance is bad as noted
# in the comments, so just don't even try. (We should check if we can make this conditional)
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@geofft can you open an issue to track this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

#645. Let's add a link in this comment if we rework this PR.

-_xxtestfuzz/fuzzer.c

_zstd:
# Disable on all targets until we add a zstd library
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This will need to come before stable, I can open an issue.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Created#646 so we don't forget, feel free to edit/rephrase.

Carol25170

This comment was marked as spam.

@zaniebzanieb marked this pull request as ready for reviewJune 4, 2025 15:39

# ./configure tries to auto-detect whether it can build 128-bit and 256-bit SIMD helpers for HACL,
# but on x86-64 that requires v2 and v3 respectively, and on arm64 the performance is bad as noted
# in the comments, so just don't even try. (We should check if we can make this conditional)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

#645. Let's add a link in this comment if we rework this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should we send this patch upstream for inclusion in 3.14?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There's a patch atpython/cpython#134276

@zaniebzanieb merged commitd2030cb intomainJun 4, 2025
211 checks passed
@zaniebzanieb deleted the zb/14b1 branchJune 4, 2025 16:20
@zaniebzanieb mentioned this pull requestJun 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@geofftgeofftgeofft approved these changes

+1 more reviewer

@Carol25170Carol25170Carol25170 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zanieb@cclauss@geofft@Carol25170@Wingysam

[8]ページ先頭

©2009-2025 Movatter.jp