When trying to update PyOxidizer and PyOxy to support standalone builds of Python 3.12, I noticed that the build attempted to link to a library namedHacl_Hash_SHA2 whenpyoxy was linked (with-lHacl_Hash_SHA2). This PR fixes the metadata inPYTHON.json.

Ensure that Hacl_Hash_SHA2 does not appear as a library to link to

dc3c2fc

ntamas mentioned this pull request

Sep 2, 2024

PYTHON.json object file annotations for 3.11 aren't aware of frozen module changes#156

Closed

zanieb approved these changes

Sep 4, 2024

View reviewed changes

Copy link

Member

zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense to me if the builds pass.

Copy link

Member

zanieb commentedSep 6, 2024

Can you share a diff of thePYTHON.json metadata?

Copy link

ContributorAuthor

ntamas commentedSep 6, 2024

Sure! I'm attaching two diffs here;full.diff was generated withdiff -u, but it contains lots of lines where the only difference is in the names of the temporary folders where the build was executed.relevant.diff was created manually fromfull.diff by deleting those chunks where the only difference was the name of the temporary folder so you can see the differences more clearly.

Both diffs are attached in a ZIP file here:diffs.zip

zanieb self-assigned this

Sep 7, 2024

Copy link

Member

zanieb commentedSep 9, 2024

Thanks! The change in the metadata makes sense to me but I don't fully understand why it was written this way in the first place?

Copy link

ContributorAuthor

ntamas commentedSep 9, 2024

I don't know either -- maybe@indygreg remembers? I think he was the one who initially wrote the code for supporting Python 3.12 where the pre-3.12 hash functions were replaced with implementations from HACL*.