Commit26cf3f3

committed

SigPrinter minor refactoring. Income Msgs as const.

1 parent44e2db2 commit26cf3f3Copy full SHA for 26cf3f3

File tree

2 files changed

+13

-13

lines changed

src/codegen
- c-sigprinter.cpp
- c-sigprinter.h

2 files changed

+13

-13

lines changed

`‎src/codegen/c-sigprinter.cpp‎`

Lines changed: 10 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,17 +23,17 @@ CSigPrinter::~CSigPrinter()`
`23`	`23`	`sigs_expr.clear();`
`24`	`24`	`}`
`25`	`25`
`26`		`-voidCSigPrinter::AddMessage(const std::vector<MessageDescriptor_t*> message)`
	`26`	`+voidCSigPrinter::LoadMessages(const std::vector<MessageDescriptor_t*> message)`
`27`	`27`	`{`
`28`	`28`	`sigs_expr.clear();`
`29`	`29`
`30`	`30`	`for (size_t i =0; i < message.size(); i++)`
`31`	`31`	`{`
`32`		`-AddMessage(*(message[i]));`
	`32`	`+LoadMessage(*(message[i]));`
`33`	`33`	`}`
`34`	`34`	`}`
`35`	`35`
`36`		`-voidCSigPrinter::AddMessage(const MessageDescriptor_t& message)`
	`36`	`+voidCSigPrinter::LoadMessage(const MessageDescriptor_t& message)`
`37`	`37`	`{`
`38`	`38`	`CiExpr_t* nexpr =new CiExpr_t;`
`39`	`39`
`@@ -94,14 +94,14 @@ int32_t CSigPrinter::BuildCConvertExprs(CiExpr_t* msg)`
`94`	`94`	`return ret;`
`95`	`95`	`}`
`96`	`96`
`97`		`-std::stringCSigPrinter::PrintSignalExpr(SignalDescriptor_t* sig,`
`98`		`-std::vector<std::string>& to_bytes)`
	`97`	`+std::stringCSigPrinter::PrintSignalExpr(constSignalDescriptor_t* sig,`
	`98`	`+ std::vector<std::string>& to_bytes)`
`99`	`99`	`{`
`100`	`100`	`// value for collecting expression (to_signal)`
`101`	`101`	`std::string tosigexpr;`
`102`	`102`
`103`	`103`	`uint16_t startb = (uint16_t)((sig->Order == BitLayout::kIntel) ?`
`104`		`-(sig->StartBit + (sig->LengthBit -1)) : (sig->StartBit));`
	`104`	`+ (sig->StartBit + (sig->LengthBit -1)) : (sig->StartBit));`
`105`	`105`
`106`	`106`	`if (startb >63)`
`107`	`107`	`startb =63;`
`@@ -118,7 +118,7 @@ std::string CSigPrinter::PrintSignalExpr(SignalDescriptor_t* sig,`
`118`	`118`	`tosigexpr += workbuff;`
`119`	`119`
`120`	`120`	`snprintf(workbuff, WBUFF_LEN,"((_m->{%s} & (%s)) << %d)", sig->Name.c_str(), msk[slen].c_str(),`
`121`		`-bbc - slen);`
	`121`	`+ bbc - slen);`
`122`	`122`	`AppendToByteLine(to_bytes[bn], workbuff);`
`123`	`123`	`}`
`124`	`124`	`elseif (bbc == slen)`
`@@ -144,7 +144,7 @@ std::string CSigPrinter::PrintSignalExpr(SignalDescriptor_t* sig,`
`144`	`144`	`tosigexpr += workbuff;`
`145`	`145`
`146`	`146`	`snprintf(workbuff, WBUFF_LEN,"((_m->%s >> %d) & (%s))", sig->Name.c_str(), slen,`
`147`		`-msk[bbc].c_str());`
	`147`	`+ msk[bbc].c_str());`
`148`	`148`	`AppendToByteLine(to_bytes[bn], workbuff);`
`149`	`149`
`150`	`150`	`while ((slen -8) >=0)`
`@@ -190,7 +190,7 @@ std::string CSigPrinter::PrintSignalExpr(SignalDescriptor_t* sig,`
`190`	`190`	`tosigexpr += workbuff;`
`191`	`191`
`192`	`192`	`snprintf(workbuff, WBUFF_LEN,"((_m->%s & (%s)) << %d)", sig->Name.c_str(), msk[slen].c_str(),`
`193`		`-8 - slen);`
	`193`	`+8 - slen);`
`194`	`194`	`AppendToByteLine(to_bytes[bn], workbuff);`
`195`	`195`	`}`
`196`	`196`	`}`
`@@ -221,4 +221,4 @@ void CSigPrinter::AppendToByteLine(std::string& expr, std::string str)`
`221`	`221`	`// First appending`
`222`	`222`	`expr = str;`
`223`	`223`	`}`
`224`		`-}`
	`224`	`+}`

`‎src/codegen/c-sigprinter.h‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,8 @@ class CSigPrinter`
`8`	`8`	`CSigPrinter();`
`9`	`9`	`~CSigPrinter();`
`10`	`10`
`11`		`-voidAddMessage(const MessageDescriptor_t& message);`
`12`		`-voidAddMessage(const std::vector<MessageDescriptor_t*> message);`
	`11`	`+voidLoadMessage(const MessageDescriptor_t& message);`
	`12`	`+voidLoadMessages(const std::vector<MessageDescriptor_t*> message);`
`13`	`13`
`14`	`14`	`public:`
`15`	`15`	`std::vector<CiExpr_t*> sigs_expr;`
`@@ -19,7 +19,7 @@ class CSigPrinter`
`19`	`19`
`20`	`20`	`int32_tBuildCConvertExprs(CiExpr_t* msg);`
`21`	`21`
`22`		`-std::stringPrintSignalExpr(SignalDescriptor_t* sig, std::vector<std::string>& to_bytes);`
	`22`	`+std::stringPrintSignalExpr(constSignalDescriptor_t* sig, std::vector<std::string>& to_bytes);`
`23`	`23`
`24`	`24`	`voidAppendToByteLine(std::string& expr, std::string str);`
`25`	`25`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit26cf3f3

File tree

2 files changed

2 files changed

`‎src/codegen/c-sigprinter.cpp‎`

`‎src/codegen/c-sigprinter.h‎`

0 commit comments