crates/cli/src/lang/injection.rs (1)

54-75:Missingdebug_assert! for double-registration, unlikelang_globs.rs.

Inlang_globs.rs (line 17–20), there is adebug_assert!(LANG_GLOBS.get().is_none(), "language globs already registered") to catch accidental double-registration in debug builds. This file lacks a similar guard. Ifregister_injetables is called twice,.set().ok() silently discards the new data, and line 61's.get().expect(...) would read thestale first registration — a subtle data-loss scenario.

Consider adding adebug_assert! for consistency:

Proposed fix

 pub fn register_injetables(injections: Vec<SerializableInjection>) -> Result<()> {+  debug_assert!(+    LANG_INJECTIONS.get().is_none(),+    "language injections already registered"+  );   let mut injectable = HashMap::new();

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.In `@crates/cli/src/lang/injection.rs` around lines 54 - 75, Add a debug-onlyassertion at the start of register_injetables to ensure we aren'tdouble-registering: call debug_assert!(LANG_INJECTIONS.get().is_none(),"language injections already registered") (and optionally do the same forINJECTABLE_LANGS if you want both guards) before building and setting the mapsso a debug build will catch accidental second registrations instead of silentlydropping the new data.

crates/cli/src/lang/lang_globs.rs (1)

153-165:Test uses the globalOnceLock — may conflict with other tests callingregister().

OnceLock can only be set once per process. Since Rust's test harness runs tests as threads in a single process, if any other test in this crate (or integration tests) also callsregister(), thedebug_assert! will fire or data will be silently dropped. This is a pre-existing test-isolation concern with global state, not introduced by this PR — just worth noting as a known limitation.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.In `@crates/cli/src/lang/lang_globs.rs` around lines 153 - 165, The test uses theglobal OnceLock LANG_GLOBS via register(), which can only be set once perprocess and will conflict with other tests; modify the test or code so testsdon't rely on global state: either add a cfg(test)-only helper to reset orinitialize LANG_GLOBS (exposing a test_reset or test_set function) and call thatfrom test_merge_with_globs, or refactor register()/LANG_GLOBS to allow injectionof a local globs instance (e.g., accept a Globs param or provide a non-globalmerge_globs_in_place) so the test can operate on a per-test Globs instanceinstead of calling the global register(); update test_merge_with_globs to usethe new helper/injectable API and reference the existing register(), LANG_GLOBS,and merge_globs symbols when making the change.