Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Dec 14, 2018. It is now read-only.
/MvcPublic archive
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

DiagnosticSource.BeforeView/AfterView not called in RenderPartial #6222

Closed
Assignees
jbagga
Labels
3 - Donebugup-for-grabsMembers of our awesome commnity can handle this issue
Milestone
@NickCraver

Description

@NickCraver

I was trying to move from wrapped views to DiagnosticSource for MVC profiling in ASP.NET Core, but I've come across a major difference in behavior.

Currently, DiagnosticSource.BeforeView and .AfterView are called for regular views (here):

DiagnosticSource.BeforeView(view,viewContext);awaitview.RenderAsync(viewContext);DiagnosticSource.AfterView(view,viewContext);

Compared to theRenderPartial (andAsync, etc.) pipeline (here):

awaitviewEngineResult.View.RenderAsync(viewContext);

...it's not wrapped in DiagnosticSource. The result is that instead of a rich profiling tree I can narrow issues down in like this:
screen shot 2017-05-01 at 19 58 33

The best I can get is:
screen shot 2017-05-01 at 19 54 36

Was this an intentional decision?

  • If so: why?
  • If not: can I submit a PR to add the.BeforeView and.AfterView calls?

Metadata

Metadata

Assignees

Labels

3 - Donebugup-for-grabsMembers of our awesome commnity can handle this issue

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions


    [8]ページ先頭

    ©2009-2025 Movatter.jp