fixDo not exposeHttpResponseMessage.Content == null to user code #386
- reenablenet6.0 tests disabled inTest Formatting assemblies w/net6.0 #384 for this issue
also, checkStream.CanSeek less when calculatingHttpMessageContent.ContentLength value
- use innerHttpContent.Headers.ContentLength if available
- this changes behaviour slightly for both requests and responses
  - observable asHttpMessageContent.Headers.ContentLength!=null for empty messages
- for responses, avoidsContentLength==null versusContentLength==0 inconsistencies (depending on platform)
- ContentLength==null may still occur in some corner cases (which existed before)
  - e.g. when innerHttpContent doesn't know its length andReadAsStreamAsync() hasn't completed
main change meansHttpResponseMessages we expose to user code are consistent across platforms
- note: user code won't seeEmptyContent inHttpResponseMessages we create

AddContent to allHttpResponseMessages

ecadf28

-fix#386  - reenable `net6.0` tests disabled in#384 for this issue- also, check `Stream.CanSeek` less when calculating `HttpMessageContent.ContentLength` value  - use inner `HttpContent.Headers.ContentLength` if available  - this changes behaviour slightly for both requests and responses    - observable as `HttpMessageContent.Headers.ContentLength!=null` for empty messages  - for responses, avoids `ContentLength==null` versus `ContentLength==0` inconsistencies (depending on platform)  - `ContentLength==null` may still occur in some corner cases (which existed before)    - e.g. when inner `HttpContent` doesn't know its length and `ReadAsStreamAsync()` hasn't completed- main change means `HttpResponseMessage`s we expose to user code are consistent across platforms  - note: user code won't see `EmptyContent` in `HttpResponseMessage`s we create

dougbu requested review fromTratcher andstephentoub

February 17, 2023 06:29

Tratcher reviewed

Feb 17, 2023

View reviewed changes

Copy link

Member

Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This version looks fine, but you say you're still seeing other issues?

Copy link

ContributorAuthor

dougbu commentedFeb 17, 2023

This version looks fine, but you say you're still seeing other issues?

Not yet. I suspect there be a few more gremlins inHttpMessageContent, at least wrt.HttpMessageContent.ValidateStreamForReading(...). I haven't filed an issue about that or anything else my testing may turn up today. My plan is to do so and fix what I find in another PR.