Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Prepare Minimal Spark Update#266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@maennchen
Copy link
Contributor

@maennchenmaennchen commentedSep 24, 2025•
edited
Loading

Contents

  • Adds:__spark_metadata__ field to all relevant struct
  • does not add any location toDslError / Warnings
  • does not fix tests forash-project/spark@2bfe3c9

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept theAI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@zachdaniel
Copy link
Contributor

@jimsynz for context here, we just don't have an option of stopping compilation via raising in a verifier unfortunately. Turns a lot of compile errors into warnings, but there just is no way around it, due to problems that causes with Elixir compiler. I'm pretty sure you're already across it, but explaining just in case.

@zachdanielzachdaniel merged commitf56b334 intoash-project:mainSep 25, 2025
20 of 22 checks passed
@maennchenmaennchen deleted the jm/spark_anno_update branchSeptember 25, 2025 06:25
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maennchen@zachdaniel
[8]ページ先頭
©2009-2025 Movatter.jp